Commit graph

3989 commits

Author SHA1 Message Date
Jackson Harper
126d79446b Clean up body of expanded audio player, remove dead code 2022-10-21 16:23:27 +08:00
Jackson Harper
a59c9910a0 Set the tab index when the expanded player is shown 2022-10-21 16:11:13 +08:00
Jackson Harper
0c7f5174c7 Open the audio player expanded the first time the user uses it. Minimize animation issues 2022-10-21 14:11:26 +08:00
Jackson Harper
663ccc1dc1 Remove NavigationView so iPad aligns to top of sheet
Also animate the miniplayer away so its not visible on ipad
when open in landscape mode.
2022-10-21 12:23:33 +08:00
Jackson Harper
578b9c6790 Split the expanded player into a new view and use a sheet to present it 2022-10-20 17:33:25 +08:00
Jackson Harper
38f107c7fe
Merge pull request #1337 from omnivore-app/fix/ios-remove-item-flicker
Fix alert/row flicker when removing items on iOS
2022-10-20 17:24:39 +08:00
Hongbo Wu
16447e1817
Merge pull request #1336 from omnivore-app/fix/delete-highlight
Delete highlights, labels and other metadata when soft delete pages
2022-10-20 12:28:11 +08:00
Jackson Harper
bca82068bd Fix alert/row flicker when removing items on iOS
This also updates the message to be consistent with Web.
2022-10-20 12:26:37 +08:00
Hongbo Wu
81b55cae0c Update wording 2022-10-20 12:22:57 +08:00
Hongbo Wu
37286f8d5e Mention highlights be deleted too 2022-10-20 12:17:02 +08:00
Hongbo Wu
a2f31c943f Fix tests 2022-10-20 11:31:39 +08:00
Hongbo Wu
e1de55bea0 Delete highlights, labels and other metadata when soft delete pages 2022-10-20 11:16:49 +08:00
Jackson Harper
77327d1929
Merge pull request #1334 from omnivore-app/fix/add-ios-getting-started
Add the iOS Saving Links article as a default read for new Omnivore users on iOS
2022-10-19 18:01:50 +08:00
Jackson Harper
fe0fe46723
Merge pull request #1335 from omnivore-app/fix/login-form-colors
Force non-themed colours on login forms as these pages are unthemed
2022-10-19 17:57:14 +08:00
Jackson Harper
69d50bcc6e Set the proper number of expected reads for iOS now that article is available 2022-10-19 17:48:22 +08:00
Jackson Harper
d5c7aa2b8f Fix linting 2022-10-19 17:36:58 +08:00
Jackson Harper
675845bebc Force non-themed colours on login forms as these pages are unthemed 2022-10-19 17:29:22 +08:00
Jackson Harper
0ad8558e92 Add the iOS Saving Links article as a default read for new Omnivore users on iOS
This also re-orders things a bit, making sure the getting started
guide is always the topmost in a user's library.
2022-10-19 17:22:30 +08:00
Jackson Harper
2542c5dbed
Merge pull request #1315 from omnivore-app/feat/subscription-icons
Display subscription icons in the iOS subscription view
2022-10-19 10:29:12 +08:00
Jackson Harper
fe3fb3ea4c
Merge pull request #1314 from omnivore-app/fix/highlight-empty-state
Empty state for the Highlights View
2022-10-19 10:28:56 +08:00
Jackson Harper
6c6e1485d9
Merge pull request #1331 from omnivore-app/fix/signup-forms
Set background colours on email forms as these pages arent themed
2022-10-18 17:53:55 +08:00
Jackson Harper
70fd1a2e84
Merge pull request #1332 from omnivore-app/welcome-articles-order
Change the order of the new user welcome articles
2022-10-18 17:53:33 +08:00
Jackson Harper
d34e5aff04 Change the order of the new user welcome articles
In the UI it will appear:

- Getting Started
- Power of Read it Later
- Organize with Labels
- (optional) iOS/Android/Web
2022-10-18 17:35:00 +08:00
Jackson Harper
359ae08c92
Merge pull request #1330 from omnivore-app/fix/loading-typo
Remove placeholder text that was showing up on loading page
2022-10-18 16:00:11 +08:00
Jackson Harper
3b53f523d8 Set background colours on email forms as these pages arent themed 2022-10-18 15:58:50 +08:00
Hongbo Wu
54032bdc97
Merge pull request #1326 from omnivore-app/fix/site-icon
fix/site icon
2022-10-18 15:49:32 +08:00
Jackson Harper
c065adad81
Merge pull request #1322 from omnivore-app/chore/apple-version-1.17-bump
bump apple versions to 1.17.0
2022-10-18 15:48:44 +08:00
Hongbo Wu
a7e92addb0 Create 128 * 128 proxy image for the site icon 2022-10-18 15:32:30 +08:00
Hongbo Wu
22e92256eb Fetch subscription's favicon if the site icon is base64 encoded image 2022-10-18 15:32:30 +08:00
Hongbo Wu
990759da73 Save base64 encoded image site icon in page 2022-10-18 15:32:30 +08:00
Hongbo Wu
0a9fc5cacc
Merge pull request #1324 from omnivore-app/fix/newsletter-node-weekly
Save newsletters hosted by cooperpress.com correctly
2022-10-18 15:31:17 +08:00
Hongbo Wu
57846a1c5e Fix tests 2022-10-18 15:14:38 +08:00
Hongbo Wu
706607ea2b Rebase main 2022-10-18 14:54:33 +08:00
Hongbo Wu
1fda6946bb Save newsletters hosted by cooper-press.com correctly 2022-10-18 14:53:02 +08:00
Hongbo Wu
58b37ccc30
Merge pull request #1321 from omnivore-app/fix/copy-popular-reads-to-dist
Copy html files to dist folder
2022-10-18 14:51:00 +08:00
Hongbo Wu
9757394a05
Merge pull request #1318 from omnivore-app/fix/newsletter-ghost-org
Save newsletters hosted by ghost.org correctly
2022-10-18 14:50:27 +08:00
Jackson Harper
5c329f6b07
Merge pull request #1329 from omnivore-app/fix/embedded-tweets-wo-parents
Handle cases where tweet items dont have parents
2022-10-18 14:11:35 +08:00
Jackson Harper
14505ef172 Remove placeholder text that was showing up on loading page 2022-10-18 13:56:31 +08:00
Jackson Harper
3f82c0af01 Handle cases where tweet items dont have parents 2022-10-18 13:46:37 +08:00
Jackson Harper
1e4b499c40
Merge pull request #1327 from omnivore-app/fix/empty-tweet-links
Better handle <a> elements with no parent when looking for tweet placeholders
2022-10-18 13:05:18 +08:00
Jackson Harper
59427fa896 Mock the substack domain also when testing redirects
We were making the actual call to the redirected URL here,
instead of mocking it. We need to mock both the embedded email
domain, and the domain we are redirected to.
2022-10-18 12:51:53 +08:00
Jackson Harper
57676d381c Better handle <a elements with no parent when looking for tweet placeholders 2022-10-18 12:13:54 +08:00
Satindar Dhillon
f73ae0a02a revert the #ifCanImport conditional. Doesn't work :( 2022-10-17 14:23:16 -07:00
Satindar Dhillon
cbc290e8e2 update pspdfkit conditional import in package.swift 2022-10-17 13:26:05 -07:00
Satindar Dhillon
66cec7f9ea bump apple versions to 1.17.0 2022-10-17 13:13:30 -07:00
Satindar Dhillon
8a3b340757
Merge pull request #1313 from omnivore-app/fix/mac-read-later
Mac App Read Now Fix
2022-10-17 13:10:24 -07:00
Hongbo Wu
3d653240b8 Copy html files to dist folder 2022-10-17 22:45:41 +08:00
Jackson Harper
7a5ef4e174
Merge pull request #1319 from omnivore-app/fix/popular-read-signup
Dont crash if a popular read is not available on signup
2022-10-17 20:57:26 +08:00
Jackson Harper
5312c31ea7 Dont crash if a popular read is not available on signup 2022-10-17 20:45:04 +08:00
Hongbo Wu
d8c5c97960 Save newsletters hosted by ghost.org correctly 2022-10-17 19:27:02 +08:00