prehistoric-systems/omnivore
1
0
Fork 0
mirror of https://github.com/omnivore-app/omnivore.git synced 2026-03-11 08:54:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #1329 from omnivore-app/fix/embedded-tweets-wo-parents

Browse source 
Handle cases where tweet items dont have parents
This commit is contained in:
Jackson Harper 2022-10-18 14:11:35 +08:00 committed by GitHub
commit 5c329f6b07
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
packages/readabilityjs/Readability.js
View file

@ -2231,12 +2231,12 @@ Readability.prototype = {
// remove all containers the tweet is nested in (if they contain the tweet only)
let tweetParent = tweet.parentElement || tweet.parentNode;
while (tweetParent && tweetParent.children.length === 1) {
while (tweetParent && tweetParent.children.length === 1 && tweetParent.parentNode) {
tweetParent.parentNode.replaceChild(tweet, tweetParent);
tweetParent = tweet.parentElement || tweet.parentNode;
}
if (tweetParent && tweetParent.className.includes('twitter-tweet')) {
if (tweetParent && tweetParent.className.includes('twitter-tweet') && tweetParent.parentNode) {
tweetParent.parentNode.replaceChild(tweet, tweetParent);
}
} else if (element.parentNode && element.parentNode.className === 'tweet') {