Commit graph

204 commits

Author SHA1 Message Date
dependabot[bot]
bcfec135ab
Bump @types/jsdom from 16.2.13 to 16.2.14
Bumps [@types/jsdom](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jsdom) from 16.2.13 to 16.2.14.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jsdom)

---
updated-dependencies:
- dependency-name: "@types/jsdom"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-02-21 21:17:58 +00:00
Jackson Harper
d911d814e9
Merge pull request #100 from omnivore-app/fix/unarchive-behavior
Use null instead of undefined when unarchiving links
2022-02-22 03:53:03 +08:00
Jackson Harper
5af4899415 Use null instead of undefined when unarchiving links
This fixes unarchiving content by re-saving it via the Save*
API methods.

Setting to undefined is not the same as null in this case, and
will result in archived_at being non-null and the link then
being excluded from the GetArticles query.
2022-02-21 11:26:22 -08:00
Jackson Harper
68416fef12
Merge pull request #95 from omnivore-app/fix/image-proxy-sizing
Handle non-number size attributes in images
2022-02-22 00:31:29 +08:00
Hongbo Wu
207f77c419
Add support for Golang Weekly newsletters (#96)
* abstract different newsletter handler to a class

* create a generic newsletter handler class

* add support for golang-weekly newsletters

* add tests for golang weekly newsletters

* use addressparser lib to parse author from from address
2022-02-21 14:37:48 +08:00
Jackson Harper
bcb90dac49 Make sure we strictly interpret img width/height values 2022-02-18 18:31:06 -08:00
Jackson Harper
603e9683db Better naming for this parsing function 2022-02-18 15:34:38 -08:00
Jackson Harper
8756a52a54 Call correct parsing method 2022-02-18 14:53:24 -08:00
Jackson Harper
612822f5a3 Handle non-number size attributes in images
The previous code assumed we would always have number size values
for width and height, but attributes like 100% are valid. In
cases where we don't have a numeric value we can just fallback
and let the item be sized by the reader CSS.
2022-02-18 14:18:36 -08:00
Satindar Dhillon
dbd698f7f2
Merge pull request #93 from omnivore-app/chore/macos-version-update
macOS OS Conditionals
2022-02-18 13:22:40 -08:00
Satindar Dhillon
9b017f8737 add os conditionals and bump version number 2022-02-18 13:17:32 -08:00
Jackson Harper
aae3250410
Merge pull request #77 from omnivore-app/fix/safari-pdf-upload-handler
On Safari fallback to SaveURL for PDFs
2022-02-19 05:00:44 +08:00
Jackson Harper
fe03d35619 Increase extension version number 2022-02-18 12:50:25 -08:00
Jackson Harper
06b3cd4b35 Update Safari extension generated code 2022-02-18 12:49:57 -08:00
Jackson Harper
f070020dd9 Fallback to SaveUrl ifd browser doesnt support blob url access (safari)
In Safari we can't access blob URLs in the background script, so
we fallback to submitting the embedded PDF URL instead of trying
to upload the content.
2022-02-18 12:48:46 -08:00
Jackson Harper
6c9e316884 Propogate errors when uploading a file fails
This cancels the wait and ensures an error is displayed
2022-02-18 12:48:46 -08:00
Jackson Harper
4c07dd56a9
Merge pull request #91 from omnivore-app/extension-v0.1.20
Bump the Safari Extension to v0.1.20
2022-02-19 04:47:34 +08:00
Jackson Harper
f61b2db632 Bump the Safari Extension to v0.1.20
This bundles some fixes for PDF saving reliability on Safari.
2022-02-18 10:48:45 -08:00
Jackson Harper
060a0876b6
Merge pull request #83 from omnivore-app/dependabot/npm_and_yarn/next-12.1.0
Bump next from 12.0.9 to 12.1.0
2022-02-19 02:47:16 +08:00
Jackson Harper
20e8029f2d
Merge pull request #85 from omnivore-app/fix/webview-scroll-offset
Set the scroll indicator offsets on the webview
2022-02-19 01:35:40 +08:00
Jackson Harper
a28857111b
Merge pull request #87 from omnivore-app/fix/typography-tweaks
Tweak the line height for reader text and titles
2022-02-18 16:52:24 +08:00
Jackson Harper
4b06e52128 Tweak the line height for reader text and titles
We still aren't using the degular font, so I kept the font sizes
the same as they are now. We will need to update if we change
the font.
2022-02-18 00:45:40 -08:00
Jackson Harper
8d743617cb Use the new verticalScrollIndicatorInsets instead of scrollIndicatorInsets 2022-02-17 21:55:22 -08:00
Jackson Harper
e757dbfe68 Use navBarHeight for the ... nav bar height 2022-02-17 21:22:19 -08:00
Satindar Dhillon
ecbe22eb53
Merge pull request #86 from omnivore-app/feature/ios-pdf-navbar
Compact Navbar for PDF Viewer [iOS]
2022-02-17 21:21:56 -08:00
Satindar Dhillon
f8d9d1aed2 set inline style nav bar for pdfviewer 2022-02-17 20:58:32 -08:00
Jackson Harper
d7d4131f9f Set the scroll indicator offsets on the webview
This prevents the scroll from bouncing when we scroll to the top
we should figure out how to query for the system navigation
bar size and use that instead of hard coding 50.
2022-02-17 20:41:13 -08:00
Satindar Dhillon
89d8b71bd4
Merge pull request #71 from omnivore-app/feature/iphone-nav-bar
iPhone NavBar Visibility
2022-02-17 20:27:36 -08:00
Hongbo Wu
4c84c40f97
add slug to the link (#84) 2022-02-18 10:43:34 +08:00
dependabot[bot]
2ff223d404
Bump next from 12.0.9 to 12.1.0
Bumps [next](https://github.com/vercel/next.js) from 12.0.9 to 12.1.0.
- [Release notes](https://github.com/vercel/next.js/releases)
- [Changelog](https://github.com/vercel/next.js/blob/canary/release.js)
- [Commits](https://github.com/vercel/next.js/compare/v12.0.9...v12.1.0)

---
updated-dependencies:
- dependency-name: next
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-02-18 02:34:10 +00:00
Satindar Dhillon
d9f32d0559 fix animation glitch 2022-02-17 16:25:24 -08:00
Satindar Dhillon
ad9d37e611 remove print statements 2022-02-17 16:08:00 -08:00
Satindar Dhillon
ea93f3926e WiP 2022-02-17 16:07:31 -08:00
Jackson Harper
05aa5d737e
Merge pull request #82 from omnivore-app/feature/bloomberg-newsletters
Add support for Bloomberg newsletter
2022-02-18 01:08:46 +08:00
Jackson Harper
f4854488c7
Merge pull request #81 from omnivore-app/fix/pdf-attachment-handler
Fix not adding pdf attachment to library
2022-02-18 01:07:51 +08:00
Hongbo Wu
9431e80be8 add parser 2022-02-17 20:17:02 +08:00
Hongbo Wu
e3839647e1 parse bloomberg newsletter 2022-02-17 20:14:06 +08:00
Hongbo Wu
ad8bca3d84 use subject as title 2022-02-17 18:59:07 +08:00
Hongbo Wu
7229c64da0
fix: Should not get fake uploading url in demo (#79)
* fix not getting fake uploading url in demo

* use internal service endpoint env

* update internal svc endpoint
2022-02-17 13:34:50 +08:00
Hongbo Wu
bd8178a464 add support for bloomberg newsletters 2022-02-17 13:19:58 +08:00
Satindar Dhillon
e929c5d1a1 remove spacing on ios reader reader 2022-02-16 21:19:07 -08:00
Satindar Dhillon
50d8310ae7 add padding around font adjustment buttons to increase tap target 2022-02-16 21:01:55 -08:00
Satindar Dhillon
0eca980993 adjust scroll content offset when nav bar toggles 2022-02-16 20:40:39 -08:00
Satindar Dhillon
45533fa562 remove scroll to top behavior on iphone reader view 2022-02-16 20:27:28 -08:00
Satindar Dhillon
e07a504daa show nav bar when user taps the status bar 2022-02-16 19:43:16 -08:00
Satindar Dhillon
69c64aa390 hide popover view when nav bar shrinks 2022-02-16 17:39:13 -08:00
Satindar Dhillon
96a02a3855 use zstack to show font adjustment view 2022-02-16 17:34:08 -08:00
Jackson Harper
7b3610d7bb
Merge pull request #78 from omnivore-app/add-github-button 2022-02-17 09:32:08 +08:00
Jackson Harper
2d663ec71b Add a link to our GitHub from our main header 2022-02-16 17:09:19 -08:00
Jackson Harper
89ae114820
Merge pull request #76 from omnivore-app/fix/apple-graphql-types
Handle the new SanitizedString types in the apple GQL source
2022-02-17 07:13:14 +08:00