Commit graph

3923 commits

Author SHA1 Message Date
Satindar Dhillon
b42ef5a5bc only call Intercom after load event is dispatched 2022-10-14 14:50:00 -07:00
Satindar Dhillon
fcef8e14e7 make sure analytics is setup before calling show on Intercom 2022-10-14 13:44:04 -07:00
Satindar Dhillon
22a5850c1e
Merge pull request #1306 from omnivore-app/fix/audio-player-crash
Dont instantiate TabView with zero items
2022-10-13 12:08:36 -07:00
Hongbo Wu
369240dff4
Merge pull request #1307 from omnivore-app/fix/escaped-utterance-in-speech-file
Do not escape utterance in speech file and do it when streaming
2022-10-13 18:11:06 +08:00
Hongbo Wu
d2c6412289 Do not escape utterance in speech file and do it when streaming 2022-10-13 16:40:46 +08:00
Jackson Harper
d9c91c3137 Reset tabIndex when state is reset to loading
We track the state of the current index in two places: the audio
controller, which updates as audio as played, the tabView has its
own binding of the current index, this is to allow scrolling.

When the audio item being played changes, we need to reset the
state of the tabIndex. We do this by watching for state loading
which occurs when new audio is loaded.
2022-10-13 15:37:37 +08:00
Jackson Harper
fe1f4ee51d Update the scrubber max value when items change 2022-10-13 15:20:28 +08:00
Jackson Harper
bafe1bd338 Ensure the audio index is updated when items are changed 2022-10-13 15:04:57 +08:00
Jackson Harper
2e9bda7835 Dont instantiate TabView with zero items
Seems this prevents the crash when the TabView tries to set
its index to 0/0.
2022-10-13 14:02:17 +08:00
Hongbo Wu
14c87a1240
Merge pull request #1298 from omnivore-app/feature/add-popular-read-when-signup
feature/add popular read when signup
2022-10-13 13:13:13 +08:00
Satindar Dhillon
8c2089d1b2
Merge pull request #1305 from omnivore-app/chore/mac-app-resurrection
Mac App Updates
2022-10-12 21:00:12 -07:00
Jackson Harper
d345aee14b
Merge pull request #1303 from omnivore-app/chore/mac-app-resurrection
Mac App Updates
2022-10-13 11:24:55 +08:00
Hongbo Wu
15d66daaca
Merge pull request #1304 from omnivore-app/fix/milkroad-newsletters
Fix not correctly identify milkroad newsletters due to the HTML format changes again by the author
2022-10-13 11:15:07 +08:00
Hongbo Wu
5dcde8dac3 Fix not correctly identify milkroad newsletters due to the HTML format changes again by the author 2022-10-13 10:52:03 +08:00
Satindar Dhillon
cd1b62b85b add min size to macos email login view frame 2022-10-12 13:33:59 -07:00
Satindar Dhillon
b3310c61c7 update buttons on welcome screen to work for macos 2022-10-12 13:23:22 -07:00
Satindar Dhillon
903e58b3c5 add empty subscriptions list message 2022-10-12 13:16:33 -07:00
Satindar Dhillon
8fcbfbbd2e fixes after rebasing 2022-10-12 12:58:32 -07:00
Satindar Dhillon
d84f41767f create a mac specific nav card 2022-10-12 10:11:11 -07:00
Satindar Dhillon
c287eb4a59 add os conditionals so the mac app compiles 2022-10-12 10:11:09 -07:00
Satindar Dhillon
460a013554
Merge pull request #1297 from omnivore-app/feat/navbar-refactor
Refactor how we do search and navbar on the library
2022-10-12 10:05:53 -07:00
Hongbo Wu
624b7b4624
Merge pull request #1294 from omnivore-app/feature/saved-search
Recent searches feature
2022-10-12 22:11:57 +08:00
Hongbo Wu
19d0d314db Fix tests 2022-10-12 18:05:17 +08:00
Jackson Harper
2b4b528c64
Merge pull request #1301 from omnivore-app/fix/substack-anchor-headers
Improvements to substack article handling
2022-10-12 15:15:45 +08:00
Jackson Harper
7af068e8dc Header fix adds the headers back in for this test case 2022-10-12 14:51:59 +08:00
Jackson Harper
989f0e2e31 Add test from the new Omnivore Getting Started article 2022-10-12 14:34:36 +08:00
Jackson Harper
57575c75aa Remove the subscriber dialog that was part of the header before 2022-10-12 14:31:34 +08:00
Hongbo Wu
7a48cccac9 Save client in request context 2022-10-12 14:30:39 +08:00
Jackson Harper
0116304284 Dont exclude substacks in article headers
Substack uses this class on header elements like <h1> to give
them anchors in the documents, but we mark content with `header`
in its class name as unlikely.
2022-10-12 14:27:31 +08:00
Hongbo Wu
9496827c6b Add popular reads to new users based on client 2022-10-12 13:59:08 +08:00
Hongbo Wu
4b7950458c Remove Redis client in api 2022-10-12 13:40:16 +08:00
Hongbo Wu
bccb949fce Save advanced search terms in search history too 2022-10-12 13:35:01 +08:00
Hongbo Wu
d4f32f7bdd Save search term in search history and update timestamp 2022-10-12 13:27:19 +08:00
Jackson Harper
5278fdd4a1 Set the X-OmnivoreClient request header 2022-10-12 12:46:10 +08:00
Hongbo Wu
8f96c167f8 Save search term in search history 2022-10-12 12:30:22 +08:00
Hongbo Wu
f30a3599ed Add REDIS_URL in env in github action 2022-10-12 12:21:52 +08:00
Hongbo Wu
1725f96d82 Add recentSearches API implementation and test 2022-10-12 12:20:48 +08:00
Hongbo Wu
fd1d43c104 Add search history repo methods 2022-10-12 10:49:07 +08:00
Hongbo Wu
ff12675713 Make user_id and term unique 2022-10-12 10:37:29 +08:00
Hongbo Wu
ab86450864 Rename X-Device to X-OmnivoreClient in the request headers 2022-10-12 10:27:39 +08:00
Jackson Harper
706021de77 Add highlighted filter option to see all items with highlights 2022-10-11 21:38:28 +08:00
Hongbo Wu
d74eee131c Add Redis in test 2022-10-11 19:10:42 +08:00
Hongbo Wu
2ba9247a98 Device info expires in 10 mins 2022-10-11 19:03:33 +08:00
Hongbo Wu
2210a38982 Set device of the request in Redis 2022-10-11 18:47:19 +08:00
Jackson Harper
25055598e3 Update read position while listening to audio 2022-10-11 17:22:40 +08:00
Jackson Harper
f047775532 Improve the replay button, give an overlay behind so its easier to see 2022-10-11 16:41:23 +08:00
Jackson Harper
476d44fbb4 Try to prevent index out of bounds issues with the tab controller 2022-10-11 16:34:52 +08:00
Jackson Harper
68f9d9d1da Give the audio controller access to the dataService so it can update read positions 2022-10-11 16:20:04 +08:00
Hongbo Wu
af9147d9d3 Add iOS popular reads to new iOS users 2022-10-11 16:07:49 +08:00
Hongbo Wu
606183829a Add popular reads to new users 2022-10-11 15:44:53 +08:00