Commit graph

235 commits

Author SHA1 Message Date
Satindar Dhillon
27b60c9cdf move primary content view into binders package 2022-02-23 09:14:45 -08:00
Satindar Dhillon
da212e8e46 remove tab bar from compact apple views 2022-02-23 08:56:12 -08:00
Satindar Dhillon
a2b968f991 remove apple waitlist code 2022-02-23 08:38:25 -08:00
Satindar Dhillon
53df427fcb remove unused settings view 2022-02-23 08:31:51 -08:00
Satindar Dhillon
a8762c5be6 move UIViewController extension file into Utils 2022-02-23 08:31:12 -08:00
Satindar Dhillon
1dacf94056
Merge pull request #111 from omnivore-app/feature/incremental-library-loading
Incremental Home Feed Loading [Apple]
2022-02-23 08:22:47 -08:00
Jackson Harper
279a3d52fb
Merge pull request #112 from omnivore-app/fix/email-help-text
Update the help text for newsletters
2022-02-22 22:28:20 -08:00
Jackson Harper
0b106791a4 Linting fixes 2022-02-22 22:16:37 -08:00
Jackson Harper
66a65d31aa Update the help text for newsletters 2022-02-22 21:58:03 -08:00
Satindar Dhillon
cc24f6cbe7 load more items if threshold index is greater than the current index 2022-02-22 21:03:01 -08:00
Satindar Dhillon
e51c4ff1b1 check item load count before loading more items 2022-02-22 20:41:16 -08:00
Jackson Harper
9dbf54c528
Merge pull request #110 from omnivore-app/mv-emails-page
Move the newsletters settings page to settings/emails
2022-02-22 19:58:14 -08:00
Jackson Harper
62073290ff Move the newsletters settings page to settings/emails
This naming makes more sense because emails can also be used
for PDF attachments.
2022-02-22 19:39:02 -08:00
Hongbo Wu
610c9c6348
Closes #37 (#109)
* change return value for new version of pubsub

* add support for the other bloomberg newsletters not only business

* add default fallback url if newsletter url not found

* revert pubsub version change
2022-02-23 11:17:59 +08:00
Satindar Dhillon
9d9c0b77f4 implement batch loading for home feed in apple apps 2022-02-22 13:50:26 -08:00
Satindar Dhillon
2645566e18
Merge pull request #108 from omnivore-app/chore/resolve-apple-warnings
Resolve lint/xcode warnings
2022-02-22 09:39:03 -08:00
Jackson Harper
d8e71386f7
Merge pull request #107 from omnivore-app/fix/api-warnings
Fix warnings in the API package
2022-02-23 01:25:47 +08:00
Satindar Dhillon
2169413554 resolve lint/xcode warnings 2022-02-22 09:17:54 -08:00
Jackson Harper
6b84148991
Merge pull request #104 from omnivore-app/dependabot/npm_and_yarn/google-cloud/pubsub-2.19.0
Bump @google-cloud/pubsub from 2.17.0 to 2.19.0
2022-02-22 09:16:10 +08:00
Jackson Harper
e9b77117c9 update to work with latest GCP API 2022-02-21 16:52:33 -08:00
Jackson Harper
5f6f3ba3b2 Fix warnings in the API package 2022-02-21 16:46:10 -08:00
Satindar Dhillon
c9c817bfb4
Merge pull request #106 from omnivore-app/chore/macos-app-review-bugs
Mac App Minor fixes
2022-02-21 15:50:19 -08:00
Jackson Harper
a9919f404f
Merge pull request #50 from omnivore-app/fix/library-content
When fetching the library item list dont add content/originalHtml from DB
2022-02-22 07:37:04 +08:00
Satindar Dhillon
12bed30fc4 remove extra quotation mark 2022-02-21 15:03:20 -08:00
Jackson Harper
a276af5264 Remove extra white space 2022-02-21 13:55:09 -08:00
Jackson Harper
cf6733c70f When fetching the library item list dont add content/originalHtml from DB 2022-02-21 13:55:09 -08:00
Jackson Harper
74f7f4aee8
Merge pull request #101 from omnivore-app/dependabot/npm_and_yarn/types/jsdom-16.2.14
Bump @types/jsdom from 16.2.13 to 16.2.14
2022-02-22 05:53:08 +08:00
Jackson Harper
f338507e91
Merge pull request #105 from omnivore-app/dependabot/npm_and_yarn/cookie-0.4.2
Bump cookie from 0.4.1 to 0.4.2
2022-02-22 05:52:35 +08:00
Satindar Dhillon
40ba684710 remove unneeded entitlements and settings menu in mac app. update extension messages 2022-02-21 13:45:24 -08:00
dependabot[bot]
23c2c547b1
Bump cookie from 0.4.1 to 0.4.2
Bumps [cookie](https://github.com/jshttp/cookie) from 0.4.1 to 0.4.2.
- [Release notes](https://github.com/jshttp/cookie/releases)
- [Changelog](https://github.com/jshttp/cookie/blob/master/HISTORY.md)
- [Commits](https://github.com/jshttp/cookie/compare/v0.4.1...v0.4.2)

---
updated-dependencies:
- dependency-name: cookie
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-02-21 21:23:32 +00:00
dependabot[bot]
6633c9a70f
Bump @google-cloud/pubsub from 2.17.0 to 2.19.0
Bumps [@google-cloud/pubsub](https://github.com/googleapis/nodejs-pubsub) from 2.17.0 to 2.19.0.
- [Release notes](https://github.com/googleapis/nodejs-pubsub/releases)
- [Changelog](https://github.com/googleapis/nodejs-pubsub/blob/main/CHANGELOG.md)
- [Commits](https://github.com/googleapis/nodejs-pubsub/compare/v2.17.0...v2.19.0)

---
updated-dependencies:
- dependency-name: "@google-cloud/pubsub"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-02-21 21:22:10 +00:00
dependabot[bot]
bcfec135ab
Bump @types/jsdom from 16.2.13 to 16.2.14
Bumps [@types/jsdom](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jsdom) from 16.2.13 to 16.2.14.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jsdom)

---
updated-dependencies:
- dependency-name: "@types/jsdom"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-02-21 21:17:58 +00:00
Jackson Harper
d911d814e9
Merge pull request #100 from omnivore-app/fix/unarchive-behavior
Use null instead of undefined when unarchiving links
2022-02-22 03:53:03 +08:00
Jackson Harper
5af4899415 Use null instead of undefined when unarchiving links
This fixes unarchiving content by re-saving it via the Save*
API methods.

Setting to undefined is not the same as null in this case, and
will result in archived_at being non-null and the link then
being excluded from the GetArticles query.
2022-02-21 11:26:22 -08:00
Jackson Harper
68416fef12
Merge pull request #95 from omnivore-app/fix/image-proxy-sizing
Handle non-number size attributes in images
2022-02-22 00:31:29 +08:00
Hongbo Wu
207f77c419
Add support for Golang Weekly newsletters (#96)
* abstract different newsletter handler to a class

* create a generic newsletter handler class

* add support for golang-weekly newsletters

* add tests for golang weekly newsletters

* use addressparser lib to parse author from from address
2022-02-21 14:37:48 +08:00
Jackson Harper
bcb90dac49 Make sure we strictly interpret img width/height values 2022-02-18 18:31:06 -08:00
Jackson Harper
603e9683db Better naming for this parsing function 2022-02-18 15:34:38 -08:00
Jackson Harper
8756a52a54 Call correct parsing method 2022-02-18 14:53:24 -08:00
Jackson Harper
612822f5a3 Handle non-number size attributes in images
The previous code assumed we would always have number size values
for width and height, but attributes like 100% are valid. In
cases where we don't have a numeric value we can just fallback
and let the item be sized by the reader CSS.
2022-02-18 14:18:36 -08:00
Satindar Dhillon
dbd698f7f2
Merge pull request #93 from omnivore-app/chore/macos-version-update
macOS OS Conditionals
2022-02-18 13:22:40 -08:00
Satindar Dhillon
9b017f8737 add os conditionals and bump version number 2022-02-18 13:17:32 -08:00
Jackson Harper
aae3250410
Merge pull request #77 from omnivore-app/fix/safari-pdf-upload-handler
On Safari fallback to SaveURL for PDFs
2022-02-19 05:00:44 +08:00
Jackson Harper
fe03d35619 Increase extension version number 2022-02-18 12:50:25 -08:00
Jackson Harper
06b3cd4b35 Update Safari extension generated code 2022-02-18 12:49:57 -08:00
Jackson Harper
f070020dd9 Fallback to SaveUrl ifd browser doesnt support blob url access (safari)
In Safari we can't access blob URLs in the background script, so
we fallback to submitting the embedded PDF URL instead of trying
to upload the content.
2022-02-18 12:48:46 -08:00
Jackson Harper
6c9e316884 Propogate errors when uploading a file fails
This cancels the wait and ensures an error is displayed
2022-02-18 12:48:46 -08:00
Jackson Harper
4c07dd56a9
Merge pull request #91 from omnivore-app/extension-v0.1.20
Bump the Safari Extension to v0.1.20
2022-02-19 04:47:34 +08:00
Jackson Harper
f61b2db632 Bump the Safari Extension to v0.1.20
This bundles some fixes for PDF saving reliability on Safari.
2022-02-18 10:48:45 -08:00
Jackson Harper
060a0876b6
Merge pull request #83 from omnivore-app/dependabot/npm_and_yarn/next-12.1.0
Bump next from 12.0.9 to 12.1.0
2022-02-19 02:47:16 +08:00