prehistoric-systems/omnivore
1
0
Fork 0
mirror of https://github.com/omnivore-app/omnivore.git synced 2026-03-11 08:54:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

allow delete internal labels

Browse source
This commit is contained in:
Hongbo Wu 2024-04-05 15:58:39 +08:00
parent 9f4f1d07ca
commit 6f03b214b5
2 changed files with 33 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
packages/api/src/repository/label.ts
View file

@ -82,7 +82,8 @@ export const labelRepository = appDataSource.getRepository(Label).extend({
},
deleteById(id: string) {
return this.delete({ id, internal: false })
// internal labels can be deleted but it will be recreated when next feed/newsletter saved
return this.delete({ id })
},
updateLabel(id: string, label: QueryDeepPartialEntity<Label>) {

41
packages/api/test/resolvers/labels.test.ts
View file

@ -193,13 +193,11 @@ describe('Labels API', () => {
})
describe('Delete label', () => {
let query: string
let labelId: string
beforeEach(() => {
query = `
mutation {
deleteLabel(id: "${labelId}") {
const query = `
mutation DeleteLabel($labelId: ID!){
deleteLabel(id: $labelId) {
... on DeleteLabelSuccess {
label {
id
@ -212,11 +210,26 @@ describe('Labels API', () => {
}
}
`
})
context('when label exists', () => {
let toDeleteLabel: Label
context('when label is internal', () => {
before(async () => {
toDeleteLabel = await createLabel('rss', '#ffffff', user.id)
labelId = toDeleteLabel.id
})
it('should delete label', async () => {
await graphqlRequest(query, authToken, {
labelId,
}).expect(200)
const label = await findLabelById(labelId, user.id)
expect(label).not.exist
})
})
context('when label is not used', () => {
before(async () => {
toDeleteLabel = await createLabel(
@ -228,7 +241,9 @@ describe('Labels API', () => {
})
it('should delete label', async () => {
await graphqlRequest(query, authToken).expect(200)
await graphqlRequest(query, authToken, {
labelId,
}).expect(200)
const label = await findLabelById(labelId, user.id)
expect(label).not.exist
})
@ -248,7 +263,9 @@ describe('Labels API', () => {
})
it('should update page', async () => {
await graphqlRequest(query, authToken).expect(200)
await graphqlRequest(query, authToken, {
labelId,
}).expect(200)
const updatedItem = await findLibraryItemById(item.id, user.id)
expect(updatedItem?.labels).not.deep.include(toDeleteLabel)
@ -283,7 +300,9 @@ describe('Labels API', () => {
})
it('should update highlight', async () => {
await graphqlRequest(query, authToken).expect(200)
await graphqlRequest(query, authToken, {
labelId,
}).expect(200)
const updatedHighlight = await findHighlightById(highlightId, user.id)
expect(updatedHighlight?.labels).not.deep.include(toDeleteLabel)
@ -297,7 +316,9 @@ describe('Labels API', () => {
})
it('should return error code NOT_FOUND', async () => {
const res = await graphqlRequest(query, authToken).expect(200)
const res = await graphqlRequest(query, authToken, {
labelId,
}).expect(200)
expect(res.body.data.deleteLabel.errorCodes).to.eql(['NOT_FOUND'])
})