From 6f03b214b5e04ce61dcab8855212e48f90a8bbf9 Mon Sep 17 00:00:00 2001
From: Hongbo Wu <hongbo@omnivore.app>
Date: Fri, 5 Apr 2024 15:58:39 +0800
Subject: [PATCH] allow delete internal labels

---
 packages/api/src/repository/label.ts       |  3 +-
 packages/api/test/resolvers/labels.test.ts | 41 ++++++++++++++++------
 2 files changed, 33 insertions(+), 11 deletions(-)

diff --git a/packages/api/src/repository/label.ts b/packages/api/src/repository/label.ts
index 9105f96eb..baaac24bb 100644
--- a/packages/api/src/repository/label.ts
+++ b/packages/api/src/repository/label.ts
@@ -82,7 +82,8 @@ export const labelRepository = appDataSource.getRepository(Label).extend({
   },
 
   deleteById(id: string) {
-    return this.delete({ id, internal: false })
+    // internal labels can be deleted but it will be recreated when next feed/newsletter saved
+    return this.delete({ id })
   },
 
   updateLabel(id: string, label: QueryDeepPartialEntity<Label>) {
diff --git a/packages/api/test/resolvers/labels.test.ts b/packages/api/test/resolvers/labels.test.ts
index 0a7608c70..8d1175c78 100644
--- a/packages/api/test/resolvers/labels.test.ts
+++ b/packages/api/test/resolvers/labels.test.ts
@@ -193,13 +193,11 @@ describe('Labels API', () => {
   })
 
   describe('Delete label', () => {
-    let query: string
     let labelId: string
 
-    beforeEach(() => {
-      query = `
-        mutation {
-          deleteLabel(id: "${labelId}") {
+    const query = `
+        mutation DeleteLabel($labelId: ID!){
+          deleteLabel(id: $labelId) {
             ... on DeleteLabelSuccess {
               label {
                 id
@@ -212,11 +210,26 @@ describe('Labels API', () => {
           }
         }
       `
-    })
 
     context('when label exists', () => {
       let toDeleteLabel: Label
 
+      context('when label is internal', () => {
+        before(async () => {
+          toDeleteLabel = await createLabel('rss', '#ffffff', user.id)
+          labelId = toDeleteLabel.id
+        })
+
+        it('should delete label', async () => {
+          await graphqlRequest(query, authToken, {
+            labelId,
+          }).expect(200)
+
+          const label = await findLabelById(labelId, user.id)
+          expect(label).not.exist
+        })
+      })
+
       context('when label is not used', () => {
         before(async () => {
           toDeleteLabel = await createLabel(
@@ -228,7 +241,9 @@ describe('Labels API', () => {
         })
 
         it('should delete label', async () => {
-          await graphqlRequest(query, authToken).expect(200)
+          await graphqlRequest(query, authToken, {
+            labelId,
+          }).expect(200)
           const label = await findLabelById(labelId, user.id)
           expect(label).not.exist
         })
@@ -248,7 +263,9 @@ describe('Labels API', () => {
         })
 
         it('should update page', async () => {
-          await graphqlRequest(query, authToken).expect(200)
+          await graphqlRequest(query, authToken, {
+            labelId,
+          }).expect(200)
 
           const updatedItem = await findLibraryItemById(item.id, user.id)
           expect(updatedItem?.labels).not.deep.include(toDeleteLabel)
@@ -283,7 +300,9 @@ describe('Labels API', () => {
         })
 
         it('should update highlight', async () => {
-          await graphqlRequest(query, authToken).expect(200)
+          await graphqlRequest(query, authToken, {
+            labelId,
+          }).expect(200)
 
           const updatedHighlight = await findHighlightById(highlightId, user.id)
           expect(updatedHighlight?.labels).not.deep.include(toDeleteLabel)
@@ -297,7 +316,9 @@ describe('Labels API', () => {
       })
 
       it('should return error code NOT_FOUND', async () => {
-        const res = await graphqlRequest(query, authToken).expect(200)
+        const res = await graphqlRequest(query, authToken, {
+          labelId,
+        }).expect(200)
 
         expect(res.body.data.deleteLabel.errorCodes).to.eql(['NOT_FOUND'])
       })