prehistoric-systems/omnivore
1
0
Fork 0
mirror of https://github.com/omnivore-app/omnivore.git synced 2026-03-11 08:54:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #642 from omnivore-app/youtube-iframes

Browse source 
Add test for readability on youtube embeds
This commit is contained in:
Hongbo Wu 2022-05-18 12:25:31 +08:00 committed by GitHub
commit 4b69fb64d4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 66 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
packages/content-fetch/youtube-handler.js
View file

@ -52,12 +52,9 @@ exports.youtubeHandler = {
<meta property="og:article:author" content="${oembed.author_name}" />
</head>
<body>
<center>
<iframe width="${width}" height="${height}" src="https://www.youtube.com/embed/${videoId}" title="${title}" frameborder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture" allowfullscreen></iframe>
</center>
<br />
<a href="${url}">${title}</a>
<div itemscope="" itemprop="author" itemtype="http://schema.org/Person">By <a href="${oembed.author_url}">${oembed.author_name}</a></div>
<p><a href="${url}" target="_blank">${title}</a></p>
<p itemscope="" itemprop="author" itemtype="http://schema.org/Person">By <a href="${oembed.author_url}" target="_blank">${oembed.author_name}</a></p>
</body>
</html>`

7
packages/puppeteer-parse/youtube-handler.js
View file

@ -52,12 +52,9 @@ exports.youtubeHandler = {
<meta property="og:article:author" content="${oembed.author_name}" />
</head>
<body>
<center>
<iframe width="${width}" height="${height}" src="https://www.youtube.com/embed/${videoId}" title="${title}" frameborder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture" allowfullscreen></iframe>
</center>
<br />
<a href="${url}">${title}</a>
<div itemscope="" itemprop="author" itemtype="http://schema.org/Person">By <a href="${oembed.author_url}">${oembed.author_name}</a></div>
<p><a href="${url}" target="_blank">${title}</a></p>
<p itemscope="" itemprop="author" itemtype="http://schema.org/Person">By <a href="${oembed.author_url}" target="_blank">${oembed.author_name}</a></p>
</body>
</html>`

11
packages/readabilityjs/test/test-pages/youtube-embed/expected-metadata.json Normal file
View file

@ -0,0 +1,11 @@
{
"title": "The Story of Celeste's Development",
"byline": "Noclip - Video Game Documentaries",
"dir": null,
"excerpt": "The Story of Celeste's Development",
"siteName": null,
"siteIcon": "",
"previewImage": "https://i.ytimg.com/vi/c3mbELVqAmo/hqdefault.jpg",
"publishedDate": null,
"readerable": false
}

8
packages/readabilityjs/test/test-pages/youtube-embed/expected.html Normal file
View file

@ -0,0 +1,8 @@
<DIV class="page" id="readability-page-1">
<iframe width="619.4690265486726" height="350" src="https://www.youtube.com/embed/c3mbELVqAmo" title="The Story of Celeste's Development" frameborder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture" allowfullscreen></iframe>
<p>
<a href="https://www.youtube.com/watch?v=c3mbELVqAmo" target="_blank"> The Story of Celeste's Development</a>
</p>
<p itemscope itemprop="author" itemtype="http://schema.org/Person"> By <a href="https://www.youtube.com/c/NoclipVideo" target="_blank">Noclip - Video Game Documentaries</a>
</p>
</DIV>

42
packages/readabilityjs/test/test-pages/youtube-embed/source.html Normal file
View file

@ -0,0 +1,42 @@
<html>
<head>
<title>The Story of Celeste's Development</title>
<meta
property="og:image"
content="https://i.ytimg.com/vi/c3mbELVqAmo/hqdefault.jpg"
/>
<meta
property="og:image:secure_url"
content="https://i.ytimg.com/vi/c3mbELVqAmo/hqdefault.jpg"
/>
<meta property="og:title" content="The Story of Celeste's Development" />
<meta property="og:description" content="" />
<meta
property="og:article:author"
content="Noclip - Video Game Documentaries"
/>
</head>
<body>
<iframe
class="omnivore-preserve"
width="619.4690265486726"
height="350"
src="https://www.youtube.com/embed/c3mbELVqAmo"
title="The Story of Celeste's Development"
frameborder="0"
allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture"
allowfullscreen
></iframe>
<p>
<a href="https://www.youtube.com/watch?v=c3mbELVqAmo" target="_blank">
The Story of Celeste's Development</a
>
</p>
<p itemscope="" itemprop="author" itemtype="http://schema.org/Person">
By
<a href="https://www.youtube.com/c/NoclipVideo" target="_blank"
>Noclip - Video Game Documentaries</a
>
</p>
</body>
</html>

1
packages/readabilityjs/test/test-pages/youtube-embed/url.txt Normal file
View file

@ -0,0 +1 @@
https://www.youtube.com/watch?v=c3mbELVqAmo