From 679550894241d2bb169f5a13b866027e25f949d9 Mon Sep 17 00:00:00 2001 From: Jackson Harper Date: Tue, 17 May 2022 12:54:43 -0700 Subject: [PATCH 1/3] Add test for readability on youtube embeds --- .../youtube-embed/expected-metadata.json | 11 +++++++++++ .../test/test-pages/youtube-embed/source.html | 18 ++++++++++++++++++ .../test/test-pages/youtube-embed/url.txt | 1 + 3 files changed, 30 insertions(+) create mode 100644 packages/readabilityjs/test/test-pages/youtube-embed/expected-metadata.json create mode 100644 packages/readabilityjs/test/test-pages/youtube-embed/source.html create mode 100644 packages/readabilityjs/test/test-pages/youtube-embed/url.txt diff --git a/packages/readabilityjs/test/test-pages/youtube-embed/expected-metadata.json b/packages/readabilityjs/test/test-pages/youtube-embed/expected-metadata.json new file mode 100644 index 000000000..da8c2869e --- /dev/null +++ b/packages/readabilityjs/test/test-pages/youtube-embed/expected-metadata.json @@ -0,0 +1,11 @@ +{ + "title": "The Story of Celeste's Development", + "byline": "Noclip - Video Game \nDocumentaries", + "dir": null, + "excerpt": "By Noclip - Video Game \nDocumentaries", + "siteName": null, + "siteIcon": "", + "previewImage": "https://i.ytimg.com/vi/c3mbELVqAmo/hqdefault.jpg", + "publishedDate": null, + "readerable": false +} diff --git a/packages/readabilityjs/test/test-pages/youtube-embed/source.html b/packages/readabilityjs/test/test-pages/youtube-embed/source.html new file mode 100644 index 000000000..02c24d5d9 --- /dev/null +++ b/packages/readabilityjs/test/test-pages/youtube-embed/source.html @@ -0,0 +1,18 @@ + + The Story of Celeste's Development + + + + + + + + +
+ The Story of Celeste's Development + + + + diff --git a/packages/readabilityjs/test/test-pages/youtube-embed/url.txt b/packages/readabilityjs/test/test-pages/youtube-embed/url.txt new file mode 100644 index 000000000..359649569 --- /dev/null +++ b/packages/readabilityjs/test/test-pages/youtube-embed/url.txt @@ -0,0 +1 @@ +https://www.youtube.com/watch?v=c3mbELVqAmo From 629aa54c58d3f24a61b8172ac05d0b0bb728471c Mon Sep 17 00:00:00 2001 From: Hongbo Wu Date: Wed, 18 May 2022 11:28:33 +0800 Subject: [PATCH 2/3] Fix youtube handler --- packages/content-fetch/youtube-handler.js | 7 ++----- packages/puppeteer-parse/youtube-handler.js | 7 ++----- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/packages/content-fetch/youtube-handler.js b/packages/content-fetch/youtube-handler.js index 1f5eed200..179e4614f 100644 --- a/packages/content-fetch/youtube-handler.js +++ b/packages/content-fetch/youtube-handler.js @@ -52,12 +52,9 @@ exports.youtubeHandler = { -
-
-
- ${title} - +

${title}

+ ` diff --git a/packages/puppeteer-parse/youtube-handler.js b/packages/puppeteer-parse/youtube-handler.js index 1f5eed200..179e4614f 100644 --- a/packages/puppeteer-parse/youtube-handler.js +++ b/packages/puppeteer-parse/youtube-handler.js @@ -52,12 +52,9 @@ exports.youtubeHandler = { -
-
-
- ${title} - +

${title}

+ ` From 0e4cec5e25f9753d1ea870317d0d465d7468aaed Mon Sep 17 00:00:00 2001 From: Hongbo Wu Date: Wed, 18 May 2022 11:28:47 +0800 Subject: [PATCH 3/3] Update tests --- .../youtube-embed/expected-metadata.json | 4 +- .../test-pages/youtube-embed/expected.html | 8 +++ .../test/test-pages/youtube-embed/source.html | 58 +++++++++++++------ 3 files changed, 51 insertions(+), 19 deletions(-) create mode 100644 packages/readabilityjs/test/test-pages/youtube-embed/expected.html diff --git a/packages/readabilityjs/test/test-pages/youtube-embed/expected-metadata.json b/packages/readabilityjs/test/test-pages/youtube-embed/expected-metadata.json index da8c2869e..1febfa04b 100644 --- a/packages/readabilityjs/test/test-pages/youtube-embed/expected-metadata.json +++ b/packages/readabilityjs/test/test-pages/youtube-embed/expected-metadata.json @@ -1,8 +1,8 @@ { "title": "The Story of Celeste's Development", - "byline": "Noclip - Video Game \nDocumentaries", + "byline": "Noclip - Video Game Documentaries", "dir": null, - "excerpt": "By Noclip - Video Game \nDocumentaries", + "excerpt": "The Story of Celeste's Development", "siteName": null, "siteIcon": "", "previewImage": "https://i.ytimg.com/vi/c3mbELVqAmo/hqdefault.jpg", diff --git a/packages/readabilityjs/test/test-pages/youtube-embed/expected.html b/packages/readabilityjs/test/test-pages/youtube-embed/expected.html new file mode 100644 index 000000000..30ef5c7ec --- /dev/null +++ b/packages/readabilityjs/test/test-pages/youtube-embed/expected.html @@ -0,0 +1,8 @@ +
+ +

+ The Story of Celeste's Development +

+ +
\ No newline at end of file diff --git a/packages/readabilityjs/test/test-pages/youtube-embed/source.html b/packages/readabilityjs/test/test-pages/youtube-embed/source.html index 02c24d5d9..4b9fa588f 100644 --- a/packages/readabilityjs/test/test-pages/youtube-embed/source.html +++ b/packages/readabilityjs/test/test-pages/youtube-embed/source.html @@ -1,18 +1,42 @@ - The Story of Celeste's Development - - - - - - - - -
- The Story of Celeste's Development - - - - + + The Story of Celeste's Development + + + + + + + + +

+ + The Story of Celeste's Development +

+ + +