fix: use textContent instead of innerText for better perf

This commit is contained in:
EnixCoda 2021-06-07 17:22:34 +08:00
parent 4e0bfee44e
commit d19b84c9ee
No known key found for this signature in database
GPG key ID: 0C1A07377913A1DD

View file

@ -44,8 +44,9 @@ export function getCurrentBranch(passive = false) {
if (branchButtonElement) {
const branchNameSpanElement = branchButtonElement.querySelector('span')
if (branchNameSpanElement) {
const partialBranchNameFromInnerText = branchNameSpanElement.innerText
if (!partialBranchNameFromInnerText.includes('…')) return partialBranchNameFromInnerText
const partialBranchNameFromInnerText = branchNameSpanElement.textContent || ''
if (partialBranchNameFromInnerText && !partialBranchNameFromInnerText.includes('…'))
return partialBranchNameFromInnerText
}
const defaultTitle = 'Switch branches or tags'
const title = branchButtonElement.title.trim()
@ -242,7 +243,8 @@ export function getPath() {
if (!pathElement?.querySelector('.js-repo-root')) {
return []
}
const path = ((pathElement as HTMLDivElement).innerText || '')
const path = ((pathElement as HTMLDivElement).textContent || '')
.trim()
.replace(/ \/ Jump to $/, '')
.trim()
.split('/')