From d19b84c9eeeb338cbec331f1a0a7b59e8dbfa494 Mon Sep 17 00:00:00 2001 From: EnixCoda Date: Mon, 7 Jun 2021 17:22:34 +0800 Subject: [PATCH] fix: use textContent instead of innerText for better perf --- src/platforms/GitHub/DOMHelper.ts | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/platforms/GitHub/DOMHelper.ts b/src/platforms/GitHub/DOMHelper.ts index 35af789..eea2f79 100644 --- a/src/platforms/GitHub/DOMHelper.ts +++ b/src/platforms/GitHub/DOMHelper.ts @@ -44,8 +44,9 @@ export function getCurrentBranch(passive = false) { if (branchButtonElement) { const branchNameSpanElement = branchButtonElement.querySelector('span') if (branchNameSpanElement) { - const partialBranchNameFromInnerText = branchNameSpanElement.innerText - if (!partialBranchNameFromInnerText.includes('…')) return partialBranchNameFromInnerText + const partialBranchNameFromInnerText = branchNameSpanElement.textContent || '' + if (partialBranchNameFromInnerText && !partialBranchNameFromInnerText.includes('…')) + return partialBranchNameFromInnerText } const defaultTitle = 'Switch branches or tags' const title = branchButtonElement.title.trim() @@ -242,7 +243,8 @@ export function getPath() { if (!pathElement?.querySelector('.js-repo-root')) { return [] } - const path = ((pathElement as HTMLDivElement).innerText || '') + const path = ((pathElement as HTMLDivElement).textContent || '') + .trim() .replace(/ \/ Jump to $/, '') .trim() .split('/')