From e1d75ee6023ba7cba510d4e3957b41a1e8b64213 Mon Sep 17 00:00:00 2001 From: Raymond Hill Date: Mon, 30 Sep 2019 08:53:02 -0400 Subject: [PATCH] Prevent reverse-lookup from finding badfilter-ed filters This could occur when clicking old entries in the logger which no longer matched the internal state of uBO. Related feedback: - https://github.com/MajkiIT/polish-ads-filter/issues/14768#issuecomment-536006312 --- src/js/reverselookup-worker.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/js/reverselookup-worker.js b/src/js/reverselookup-worker.js index 0983e578d..2c207e22f 100644 --- a/src/js/reverselookup-worker.js +++ b/src/js/reverselookup-worker.js @@ -49,6 +49,9 @@ const extractBlocks = function(content, begId, endId) { /******************************************************************************/ +// https://github.com/MajkiIT/polish-ads-filter/issues/14768#issuecomment-536006312 +// Avoid reporting badfilter-ed filters. + const fromNetFilter = function(details) { const lists = []; const compiledFilter = details.compiledFilter; @@ -56,7 +59,7 @@ const fromNetFilter = function(details) { for ( const assetKey in listEntries ) { const entry = listEntries[assetKey]; if ( entry === undefined ) { continue; } - const content = extractBlocks(entry.content, 0, 1000); + const content = extractBlocks(entry.content, 0, 0); let pos = 0; for (;;) { pos = content.indexOf(compiledFilter, pos);