From dd394ebba51723c89e063caecae3bfa71729af77 Mon Sep 17 00:00:00 2001 From: gorhill Date: Sat, 4 Jul 2015 17:34:18 -0400 Subject: [PATCH] code review: regex perf as per https://www.loggly.com/blog/five-invaluable-techniques-to-improve-regex-performance/ --- src/js/static-net-filtering.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/js/static-net-filtering.js b/src/js/static-net-filtering.js index c684e9a21..fd23afd30 100644 --- a/src/js/static-net-filtering.js +++ b/src/js/static-net-filtering.js @@ -193,9 +193,10 @@ var strToRegex = function(s, anchor, flags) { return alwaysTruePseudoRegex; } + // https://www.loggly.com/blog/five-invaluable-techniques-to-improve-regex-performance/ // https://developer.mozilla.org/en/docs/Web/JavaScript/Guide/Regular_Expressions var reStr = s.replace(/[.+?^${}()|[\]\\]/g, '\\$&') - .replace(/\*/g, '.*'); + .replace(/\*/g, '[^ ]*?'); if ( anchor < 0 ) { reStr = '^' + reStr;