From da605f53a6ab9e6b9fd0c52688164dc3c5706089 Mon Sep 17 00:00:00 2001
From: gorhill <rhill@raymondhill.net>
Date: Sun, 5 Nov 2017 06:45:43 -0500
Subject: [PATCH] code review: avoid pointless test for single-char cells

---
 src/js/hntrie.js | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/js/hntrie.js b/src/js/hntrie.js
index 04555030c..3afe60ad1 100644
--- a/src/js/hntrie.js
+++ b/src/js/hntrie.js
@@ -400,8 +400,8 @@ HNTrieBuilder.prototype.HNTrie8.prototype.matches = function(needle) {
         }
         if ( c1 === 0 ) { return true; }
         ccnt = this.buf[i+3];
-        if ( ccnt > ichar ) { return false; }
         if ( ccnt !== 0 ) {                         // cell is only one character
+            if ( ccnt > ichar ) { return false; }
             ic = ccnt; i1 = ichar-1; i2 = i+4;
             while ( ic-- && needle.charCodeAt(i1-ic) === this.buf[i2+ic] );
             if ( ic !== -1 ) { return false; }
@@ -431,8 +431,8 @@ HNTrieBuilder.prototype.HNTrie16.prototype.matches = function(needle) {
         }
         if ( c1 === 0 ) { return true; }
         ccnt = this.buf[i+3];
-        if ( ccnt > ichar ) { return false; }
         if ( ccnt !== 0 ) {                         // cell is only one character
+            if ( ccnt > ichar ) { return false; }
             ic = ccnt; i1 = ichar-1; i2 = i+4;
             while ( ic-- && needle.charCodeAt(i1-ic) === this.buf[i2+ic] );
             if ( ic !== -1 ) { return false; }
@@ -462,8 +462,8 @@ HNTrieBuilder.prototype.HNTrie32.prototype.matches = function(needle) {
         }
         if ( c1 === 0 ) { return true; }
         ccnt = this.buf[i+3];
-        if ( ccnt > ichar ) { return false; }
         if ( ccnt !== 0 ) {                         // cell is only one character
+            if ( ccnt > ichar ) { return false; }
             ic = ccnt; i1 = ichar-1; i2 = i+4;
             while ( ic-- && needle.charCodeAt(i1-ic) === this.buf[i2+ic] );
             if ( ic !== -1 ) { return false; }