From d9055b0307f66e8af9edcfc53a41f54a50a44b5e Mon Sep 17 00:00:00 2001 From: Raymond Hill Date: Fri, 14 Nov 2025 10:01:09 -0500 Subject: [PATCH] [mv3] Minor code review related to permission changes Related commit: https://github.com/gorhill/uBlock/commit/801b4679e9d6ffcf15d86c44a2122fa62e9779b2 --- platform/mv3/extension/js/background.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/platform/mv3/extension/js/background.js b/platform/mv3/extension/js/background.js index b12c54a2f..c738a1880 100644 --- a/platform/mv3/extension/js/background.js +++ b/platform/mv3/extension/js/background.js @@ -150,7 +150,8 @@ async function onPermissionGrantedThruExtension(details, origins) { async function onPermissionGrantedThruBrowser(origins) { const modified = await syncWithBrowserPermissions(); if ( modified === false ) { return; } - await Promise.all([ updateSessionRules(), registerInjectables() ]); + await registerInjectables(); + if ( rulesetConfig.autoReload !== true ) { return; } if ( origins.length !== 1 ) { return; } const tabs = await browser.tabs.query({ active: true, currentWindow: true }); const tabId = tabs?.[0]?.id; @@ -175,10 +176,9 @@ async function onPermissionsAdded(permissions) { const details = pendingPermissionRequest; pendingPermissionRequest = undefined; const { origins = [] } = permissions; - if ( details !== undefined ) { - return onPermissionGrantedThruExtension(details, origins); - } - onPermissionGrantedThruBrowser(origins); + return details !== undefined + ? onPermissionGrantedThruExtension(details, origins) + : onPermissionGrantedThruBrowser(origins); } async function onPermissionsRemoved() {