From d827accdf0f77ae9ebc79396ae912583a611aa26 Mon Sep 17 00:00:00 2001 From: gorhill Date: Tue, 25 Oct 2016 10:20:29 -0400 Subject: [PATCH] fix FF add-on validator warning --- src/js/i18n.js | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/src/js/i18n.js b/src/js/i18n.js index 1ff610e8a..c681f9995 100644 --- a/src/js/i18n.js +++ b/src/js/i18n.js @@ -61,7 +61,22 @@ var safeTextToTagNode = function(text) { node.setAttribute('type', matches[2]); return node; } - return document.createElement(text); + // Firefox extension validator warns if using a variable as argument for + // document.createElement(). + switch ( text ) { + case 'b': + return document.createElement('b'); + case 'code': + return document.createElement('code'); + case 'em': + return document.createElement('em'); + case 'i': + return document.createElement('i'); + case 'span': + return document.createElement('span'); + default: + break; + } }; var safeTextToTextNode = function(text) {