prehistoric-systems/uBlock
1
0
Fork 0
mirror of https://github.com/gorhill/uBlock.git synced 2026-03-11 09:04:36 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

#1378: oops -- this is the proper fix

Browse source
This commit is contained in:
gorhill 2016-02-14 11:02:43 -05:00
parent ced9f68918
commit d42f72caac
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/js/tab.js
View file

@ -524,6 +524,11 @@ vAPI.tabs.onPopupUpdated = (function() {
// See if two URLs are different, disregarding scheme -- because the scheme // See if two URLs are different, disregarding scheme -- because the scheme
// can be unilaterally changed by the browser. // can be unilaterally changed by the browser.
var areDifferentURLs = function(a, b) { var areDifferentURLs = function(a, b) {
// https://github.com/gorhill/uBlock/issues/1378
// Maybe no link element was clicked.
if ( b === '' ) {
return true;
}
var pos = a.indexOf('://'); var pos = a.indexOf('://');
if ( pos === -1 ) { if ( pos === -1 ) {
return false; return false;
@ -561,7 +566,6 @@ vAPI.tabs.onPopupUpdated = (function() {
// Check user switch first // Check user switch first
if ( if (
popupType !== 'popunder' && popupType !== 'popunder' &&
clickedURL !== '' &&
areDifferentURLs(targetURL, clickedURL) && areDifferentURLs(targetURL, clickedURL) &&
µb.hnSwitches.evaluateZ('no-popups', openerHostname) µb.hnSwitches.evaluateZ('no-popups', openerHostname)
) { ) {