From c8860ff61dcdd371b154b61f21faab36031caf1f Mon Sep 17 00:00:00 2001 From: Raymond Hill Date: Sun, 30 Jun 2019 10:22:06 -0400 Subject: [PATCH] Code review of https://github.com/gorhill/uBlock/commit/c1bdc123f243565e5899dd2b8629480fb4477d8a --- src/js/scriptlets/element-picker.js | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/src/js/scriptlets/element-picker.js b/src/js/scriptlets/element-picker.js index c8779c23e..64620f455 100644 --- a/src/js/scriptlets/element-picker.js +++ b/src/js/scriptlets/element-picker.js @@ -990,13 +990,17 @@ const filterToDOMInterface = (( ) => { cssSelectors.add(item.raw); } } - vAPI.domFilterer.addCSSRule( - Array.from(cssSelectors), - 'display:none!important;' - ); - vAPI.domFilterer.addProceduralSelectors( - Array.from(proceduralSelectors) - ); + if ( cssSelectors.size !== 0 ) { + vAPI.domFilterer.addCSSRule( + Array.from(cssSelectors), + 'display:none!important;' + ); + } + if ( proceduralSelectors.size !== 0 ) { + vAPI.domFilterer.addProceduralSelectors( + Array.from(proceduralSelectors) + ); + } }); };