From c6227289a627d48b9c88ff95b4dd2a51836e3c7c Mon Sep 17 00:00:00 2001 From: Raymond Hill Date: Thu, 27 Nov 2014 09:41:28 -0200 Subject: [PATCH] code review --- src/js/contentscript-end.js | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/src/js/contentscript-end.js b/src/js/contentscript-end.js index 6eeda9f80..4cd84bc2a 100644 --- a/src/js/contentscript-end.js +++ b/src/js/contentscript-end.js @@ -55,17 +55,19 @@ var messager = vAPI.messaging.channel('contentscript-end.js'); // Ensure injected styles are enforced // rhill 2014-11-16: not sure this is needed anymore. Test case in // above issue was fine without the line below.. - if ( vAPI.hideCosmeticFilters ) { - hideElements(Object.keys(vAPI.hideCosmeticFilters).join(',')); + var selectors = vAPI.hideCosmeticFilters; + if ( typeof selectors === 'object' ) { + hideElements(Object.keys(selectors).join(',')); } // Add exception filters into injected filters collection, in order // to force them to be seen as "already injected". - var donthideCosmeticFilters = vAPI.donthideCosmeticFilters; - for ( var selector in donthideCosmeticFilters ) { - if ( donthideCosmeticFilters.hasOwnProperty(selector) === false ) { - continue; + selectors = vAPI.donthideCosmeticFilters; + if ( typeof selectors === 'object' ) { + for ( var selector in selectors ) { + if ( selectors.hasOwnProperty(selector) ) { + injectedSelectors[selector] = true; + } } - injectedSelectors[selector] = true; } // Now scan content of page idsFromNodeList(document.querySelectorAll('[id]'));