From c0515c20a4bb9935e88f8e7cc7f5ad8d75773cdc Mon Sep 17 00:00:00 2001 From: gorhill Date: Thu, 16 Jun 2016 09:15:49 -0400 Subject: [PATCH] set a limit on longth of suggested network filters (see https://github.com/gorhill/uBlock/issues/1725#issuecomment-226479197) --- src/js/scriptlets/element-picker.js | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/js/scriptlets/element-picker.js b/src/js/scriptlets/element-picker.js index 5a5ae00d7..b48c41e79 100644 --- a/src/js/scriptlets/element-picker.js +++ b/src/js/scriptlets/element-picker.js @@ -336,18 +336,21 @@ var backgroundImageURLFromElement = function(elem) { /******************************************************************************/ +// https://github.com/gorhill/uBlock/issues/1725#issuecomment-226479197 +// Limit returned string to 2048 characters. + var resourceURLFromElement = function(elem) { var tagName = elem.localName, s; if ( (s = netFilter1stSources[tagName]) ) { s = elem[s]; if ( typeof s === 'string' && s !== '' ) { - return s; + return s.slice(0, 2048); } } if ( (s = netFilter2ndSources[tagName]) ) { s = elem[s]; if ( typeof s === 'string' && s !== '' ) { - return s; + return s.slice(0, 2048); } } return backgroundImageURLFromElement(elem);