From b1e92fdbaa5fbf568e64fb1116cd6db96435c254 Mon Sep 17 00:00:00 2001 From: gorhill Date: Sat, 12 Jul 2014 22:53:17 -0400 Subject: [PATCH] comments --- js/element-picker.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/js/element-picker.js b/js/element-picker.js index 9910a04dd..db7465ee6 100644 --- a/js/element-picker.js +++ b/js/element-picker.js @@ -112,7 +112,8 @@ /******************************************************************************/ /******************************************************************************/ -// Cut & pasted here because this is an injected script. +// Cut & pasted here from reference implementation in messagin-client.js +// because this is an injected script. var messaging = (function(name){ var port = null; @@ -736,6 +737,10 @@ var startPicker = function(details) { svgIslands = svgRoot.querySelector('path + path'); pickerRoot.appendChild(svgRoot); + // TODO: do not rely on element ids, they could collide with whatever + // is used in the page. Just use built-in hierarchy of elements as + // selectors. + divDialog = document.createElement('div'); divDialog.innerHTML = [ '
',