From ad2add46764a9281f03e01a54be41cd8e3fe48f2 Mon Sep 17 00:00:00 2001 From: Raymond Hill Date: Sat, 12 Apr 2025 08:08:12 -0400 Subject: [PATCH] Code review --- src/js/scriptlet-filtering.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/js/scriptlet-filtering.js b/src/js/scriptlet-filtering.js index c61444bb6..7980a4064 100644 --- a/src/js/scriptlet-filtering.js +++ b/src/js/scriptlet-filtering.js @@ -317,7 +317,7 @@ export class ScriptletFilteringEngineEx extends ScriptletFilteringEngine { filters: scriptletDetails.filters, }; - if ( request.nocache !== true ) { + if ( hostname !== '' && request.nocache !== true ) { this.scriptletCache.add(hostname, cachedScriptletDetails); } @@ -328,7 +328,6 @@ export class ScriptletFilteringEngineEx extends ScriptletFilteringEngine { if ( typeof details.frameId !== 'number' ) { return; } const hostname = hostnameFromURI(details.url); - if ( hostname === '' ) { return; } const domain = domainFromHostname(hostname); const scriptletDetails = this.retrieve({