From ac6211f1afe498cdb4aa5987eb0685ae518cf901 Mon Sep 17 00:00:00 2001 From: Chris Date: Mon, 9 Feb 2015 19:31:21 -0700 Subject: [PATCH] Fixes #721; popover works in tabs without explicit URL --- platform/safari/vapi-background.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/platform/safari/vapi-background.js b/platform/safari/vapi-background.js index 672a56d70..cf549f1db 100644 --- a/platform/safari/vapi-background.js +++ b/platform/safari/vapi-background.js @@ -240,7 +240,7 @@ index: tab.browserWindow.tabs.indexOf(tab), windowId: safari.application.browserWindows.indexOf(tab.browserWindow), active: tab === tab.browserWindow.activeTab, - url: tab.url, + url: tab.url || "about:blank", title: tab.title }); }; @@ -272,7 +272,9 @@ var url = details.url.replace(rgxHash, ''); for(var i = 0; i < win.tabs.length; i++) { - if(win.tabs[i].url.replace(rgxHash, '') === url) { + // Some tabs don't have a URL + if(win.tabs[i].url && + win.tabs[i].url.replace(rgxHash, '') === url) { win.tabs[i].activate(); return true; }