From a3f7392f068fd997d4732da075eb778497b27763 Mon Sep 17 00:00:00 2001 From: Raymond Hill Date: Fri, 29 Dec 2017 20:33:24 -0500 Subject: [PATCH] code review: mind length of data available --- src/js/traffic.js | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/js/traffic.js b/src/js/traffic.js index b894b8d26..825e51495 100644 --- a/src/js/traffic.js +++ b/src/js/traffic.js @@ -603,6 +603,7 @@ var filterDocument = (function() { } // We need to insert after DOCTYPE, or else the browser may falls into // quirks mode. + if ( responseBytes.byteLength < 256 ) { return false; } var bb = new Uint8Array(responseBytes, 0, 256), i = 0, b; // Skip BOM if present. @@ -638,15 +639,11 @@ var filterDocument = (function() { if ( (qcount & 1) !== 0 ) { return false; } // We found a valid insertion point. if ( textEncoder === undefined ) { textEncoder = new TextEncoder(); } - filterer.stream.write( - new Uint8Array(responseBytes, 0, i) - ); + filterer.stream.write(new Uint8Array(responseBytes, 0, i)); filterer.stream.write( textEncoder.encode('') ); - filterer.stream.write( - new Uint8Array(responseBytes, i) - ); + filterer.stream.write(new Uint8Array(responseBytes, i)); filterer.stream.disconnect(); return true; };