From 9a60573abe0d9054eed2bbd3294414dc2dbc6923 Mon Sep 17 00:00:00 2001 From: Raymond Hill Date: Mon, 12 Jul 2021 18:32:32 -0400 Subject: [PATCH] Fix broken "Block element..." case when cosmetic filtering is off Related feedback: - https://github.com/gorhill/uBlock/commit/e983f9a76e1ace241410e384bba1968fd1f93aae#commitcomment-53382148 --- src/js/scriptlets/epicker.js | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/src/js/scriptlets/epicker.js b/src/js/scriptlets/epicker.js index 9ae3971a4..16565d085 100644 --- a/src/js/scriptlets/epicker.js +++ b/src/js/scriptlets/epicker.js @@ -1052,9 +1052,11 @@ const startPicker = function() { const elems = document.getElementsByTagName(tagName); for ( const elem of elems ) { if ( elem === pickerRoot ) { continue; } - const src = elem[attr]; - if ( typeof src !== 'string' ) { continue; } - if ( (src !== url) && (src !== '' || url !== 'about:blank') ) { + const srcs = resourceURLsFromElement(elem); + if ( + (srcs.length !== 0 && srcs.includes(url) === false) || + (srcs.length === 0 && url !== 'about:blank') + ) { continue; } filtersFrom(elem); @@ -1062,7 +1064,13 @@ const startPicker = function() { netFilterCandidates.length !== 0 || cosmeticFilterCandidates.length !== 0 ) { - elem.scrollIntoView({ behavior: 'smooth', block: 'center' }); + if ( pickerBootArgs.mouse !== true ) { + elem.scrollIntoView({ + behavior: 'smooth', + block: 'center', + inline: 'center' + }); + } showDialog({ broad: true }); } return;