From 70ab1a26de0e6304fc5a997b9168edd9255baa72 Mon Sep 17 00:00:00 2001 From: gorhill Date: Mon, 17 Oct 2016 09:37:59 -0400 Subject: [PATCH] code review re. #1884, as per feedback at https://bugs.chromium.org/p/chromium/issues/detail?id=637577#c15 --- src/js/traffic.js | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/js/traffic.js b/src/js/traffic.js index 07ec05939..e738aeeae 100644 --- a/src/js/traffic.js +++ b/src/js/traffic.js @@ -293,16 +293,17 @@ var onBeforeBehindTheSceneRequest = function(details) { context.requestHostname = µb.URI.hostnameFromURI(requestURL); context.requestType = requestType; - // "g" in "gb:" stands for "global setting" - if ( requestType === 'beacon' && µb.userSettings.hyperlinkAuditingDisabled ) { - result = 'gb:no-hyperlink-auditing'; - } + // https://bugs.chromium.org/p/chromium/issues/detail?id=637577#c15 + // Do not filter behind-the-scene network request of type `beacon`: there + // is no point. In any case, this will become a non-issue once + // is + // fixed. // Blocking behind-the-scene requests can break a lot of stuff: prevent // browser updates, prevent extension updates, prevent extensions from // working properly, etc. // So we filter if and only if the "advanced user" mode is selected - if ( result === '' && µb.userSettings.advancedUserEnabled ) { + if ( µb.userSettings.advancedUserEnabled ) { result = pageStore.filterRequestNoCache(context); }