From 60ee64e4bb0482fdf570d971397effb3fc70b2fc Mon Sep 17 00:00:00 2001 From: Raymond Hill Date: Tue, 14 Aug 2018 18:47:59 -0400 Subject: [PATCH] fix #168: Firefox for Android does not support the windows API --- platform/chromium/vapi-background.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/platform/chromium/vapi-background.js b/platform/chromium/vapi-background.js index fc204f1c8..678f1588b 100644 --- a/platform/chromium/vapi-background.js +++ b/platform/chromium/vapi-background.js @@ -490,7 +490,9 @@ vAPI.tabs.open = function(details) { }; // Open in a standalone window - if ( details.popup === true ) { + // https://github.com/uBlockOrigin/uBlock-issues/issues/168#issuecomment-413038191 + // Not all platforms support browser.windows API. + if ( details.popup === true && chrome.windows instanceof Object ) { chrome.windows.create({ url: details.url, type: 'popup' }); return; }