From 5f4d97596698b32763b54d50d5c75cc989148fb5 Mon Sep 17 00:00:00 2001
From: gorhill <rhill@raymondhill.net>
Date: Sat, 2 May 2015 00:13:19 -0400
Subject: [PATCH] code review

---
 platform/chromium/manifest.json      |  4 ++--
 platform/chromium/vapi-background.js |  3 +--
 src/js/async.js                      | 30 ++++++++++++++--------------
 3 files changed, 18 insertions(+), 19 deletions(-)

diff --git a/platform/chromium/manifest.json b/platform/chromium/manifest.json
index 1ae78f54b..ab646d2f9 100644
--- a/platform/chromium/manifest.json
+++ b/platform/chromium/manifest.json
@@ -13,8 +13,8 @@
 
     "browser_action": {
         "default_icon": {
-            "19": "img/browsericons/icon19-off.png",
-            "38": "img/browsericons/icon38-off.png"
+            "19": "img/browsericons/icon19.png",
+            "38": "img/browsericons/icon38.png"
         },
         "default_title": "uBlock Origin",
         "default_popup": "popup.html"
diff --git a/platform/chromium/vapi-background.js b/platform/chromium/vapi-background.js
index 98ee10fdb..decab1909 100644
--- a/platform/chromium/vapi-background.js
+++ b/platform/chromium/vapi-background.js
@@ -747,8 +747,7 @@ vAPI.onLoadAllCompleted = function() {
         }
     };
 
-    chrome.tabs.query({ url: 'http://*/*' }, bindToTabs);
-    chrome.tabs.query({ url: 'https://*/*' }, bindToTabs);
+    chrome.tabs.query({ url: '<all_urls>' }, bindToTabs);
 };
 
 /******************************************************************************/
diff --git a/src/js/async.js b/src/js/async.js
index c86fc8c5e..b30678c18 100644
--- a/src/js/async.js
+++ b/src/js/async.js
@@ -172,32 +172,32 @@ return asyncJobManager;
 // Update visual of extension icon.
 
 µBlock.updateBadgeAsync = (function() {
-    var µb = µBlock;
-    var tabIdToTimer = {};
+    var tabIdToTimer = Object.create(null);
 
     var updateBadge = function(tabId) {
         delete tabIdToTimer[tabId];
 
-        var pageStore = µb.pageStoreFromTabId(tabId);
-        if ( pageStore === null ) {
-            return;
+        var state = false;
+        var badge = '';
+
+        var pageStore = this.pageStoreFromTabId(tabId);
+        if ( pageStore !== null ) {
+            state = pageStore.getNetFilteringSwitch();
+            if ( state && this.userSettings.showIconBadge && pageStore.perLoadBlockedRequestCount ) {
+                badge = this.utils.formatCount(pageStore.perLoadBlockedRequestCount);
+            }
         }
 
-        var netFiltering = pageStore.getNetFilteringSwitch();
-        var badge = '';
-        if ( µb.userSettings.showIconBadge && netFiltering && pageStore.perLoadBlockedRequestCount ) {
-            badge = µb.utils.formatCount(pageStore.perLoadBlockedRequestCount);
-        }
-        vAPI.setIcon(tabId, netFiltering ? 'on' : 'off', badge);
+        vAPI.setIcon(tabId, state ? 'on' : 'off', badge);
     };
 
     return function(tabId) {
+        if ( tabIdToTimer[tabId] ) {
+            return;
+        }
         if ( vAPI.isBehindTheSceneTabId(tabId) ) {
             return;
         }
-        if ( tabIdToTimer.hasOwnProperty(tabId) ) {
-            return;
-        }
-        tabIdToTimer[tabId] = setTimeout(updateBadge.bind(null, tabId), 500);
+        tabIdToTimer[tabId] = setTimeout(updateBadge.bind(this, tabId), 500);
     };
 })();