From 51983afb0e6713c5b1a3a5995b6881bcabeda9c3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Emilio=20Cobos=20=C3=81lvarez?= Date: Wed, 1 Jun 2022 21:26:58 +0200 Subject: [PATCH] dom-inspector/element-picker: Ensure frame background is transparent. This fixes the element picker on dark color-scheme websites on Firefox Nightly and Chrome Canary at least, see: * https://bugzilla.mozilla.org/show_bug.cgi?id=1771047 * https://github.com/w3c/csswg-drafts/issues/4772 This improves on the existing (not quite correct, was relying on a Chromium bug) fix for Chromium browsers. --- src/js/scriptlets/epicker.js | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/src/js/scriptlets/epicker.js b/src/js/scriptlets/epicker.js index 124909a77..e288e78b0 100644 --- a/src/js/scriptlets/epicker.js +++ b/src/js/scriptlets/epicker.js @@ -1281,19 +1281,11 @@ const pickerCSSStyle = [ 'visibility: visible', 'width: 100%', 'z-index: 2147483647', + // https://github.com/uBlockOrigin/uBlock-issues/issues/1408 + 'color-scheme: light', '' ]; -// https://github.com/uBlockOrigin/uBlock-issues/issues/1408 -// We need to reset Chromium-specific `color-scheme` property -// for our iframe widget. -if ( - CSS.supports instanceof Function && - CSS.supports('color-scheme', 'initial') -) { - pickerCSSStyle.push('color-scheme: initial'); -} - const pickerCSS = ` :root > [${vAPI.sessionId}] { ${pickerCSSStyle.join(' !important;')}