prehistoric-systems/uBlock
1
0
Fork 0
mirror of https://github.com/gorhill/uBlock.git synced 2026-03-11 09:04:36 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

code review: avoid Array.splice/unshift

Browse source 
The array size stays the same, items are just moved around.
This commit is contained in:
Raymond Hill 2017-12-22 09:37:26 -05:00
parent 607968de7f
commit 4ab63e70fe
No known key found for this signature in database
GPG key ID: 25E1490B761470C2
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/js/utils.js
View file

@ -373,8 +373,11 @@
lookup: function(key) { lookup: function(key) {
var value = this.map.get(key); var value = this.map.get(key);
if ( value !== undefined && this.array[0] !== key ) { if ( value !== undefined && this.array[0] !== key ) {
this.array.splice(this.array.indexOf(key), 1); var i = this.array.indexOf(key);
this.array.unshift(key); do {
this.array[i] = this.array[i-1];
} while ( --i );
this.array[0] = key;
} }
return value; return value;
}, },