From 431b40f8e45dbddc11020a3370c4ff3260b2ef5b Mon Sep 17 00:00:00 2001 From: Raymond Hill Date: Wed, 21 Mar 2018 08:42:21 -0400 Subject: [PATCH] code review for 6871d9aed432 --- src/css/dyna-rules.css | 3 +++ src/js/dyna-rules.js | 7 +++---- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/css/dyna-rules.css b/src/css/dyna-rules.css index bab91c51a..e71a398a5 100644 --- a/src/css/dyna-rules.css +++ b/src/css/dyna-rules.css @@ -37,6 +37,9 @@ body { #ruleFilter { text-align: center; } +#ruleFilter .fa { + color: #888; + } body[dir="ltr"] #revertButton:after { content: '\2009\f061'; font-family: FontAwesome; diff --git a/src/js/dyna-rules.js b/src/js/dyna-rules.js index ba29b816b..15d05d89b 100644 --- a/src/js/dyna-rules.js +++ b/src/js/dyna-rules.js @@ -284,15 +284,14 @@ var onFilterChanged = (function() { var process = function() { timer = undefined; if ( mergeView.editor().isClean(cleanEditToken) === false ) { return; } + var filter = uDom('#ruleFilter input').val(); + if ( filter === last ) { return; } + last = filter; if ( overlay !== null ) { mergeView.leftOriginal().removeOverlay(overlay); mergeView.editor().removeOverlay(overlay); overlay = null; } - var filter = uDom('#ruleFilter input').val(); - if ( filter === last ) { return; } - last = filter; - if ( filter !== '' ) { overlay = updateOverlay(filter); mergeView.leftOriginal().addOverlay(overlay);