From 3e6333d02bd93ab0aee6faef35ec3cebf5382d89 Mon Sep 17 00:00:00 2001 From: Raymond Hill Date: Sun, 14 Jan 2024 13:29:58 -0500 Subject: [PATCH] Further fine tune visual as per feedback Related issue: https://github.com/uBlockOrigin/uBlock-issues/issues/3066#issuecomment-1891023881 --- src/css/3p-filters.css | 3 ++- src/js/3p-filters.js | 6 +++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/css/3p-filters.css b/src/css/3p-filters.css index 483c62274..2024d18d5 100644 --- a/src/css/3p-filters.css +++ b/src/css/3p-filters.css @@ -15,7 +15,8 @@ body { #buttonUpdate.active { pointer-events: none; } -#buttonUpdate.active .fa-icon svg { +#buttonUpdate.active .fa-icon svg, +body.working #buttonUpdate:not(.disabled) .fa-icon svg { animation: spin 1s linear infinite; transform-origin: 50%; } diff --git a/src/js/3p-filters.js b/src/js/3p-filters.js index c59365fd7..8441df9da 100644 --- a/src/js/3p-filters.js +++ b/src/js/3p-filters.js @@ -286,14 +286,14 @@ const renderFilterLists = ( ) => { /******************************************************************************/ const renderWidgets = ( ) => { + const updating = dom.cl.has(dom.body, 'updating'); + const hasObsolete = qs$('#lists .listEntry.checked.obsolete:not(.toRemove)') !== null; dom.cl.toggle('#buttonApply', 'disabled', filteringSettingsHash === hashFromCurrentFromSettings() ); - const updating = dom.cl.has(dom.body, 'updating'); dom.cl.toggle('#buttonUpdate', 'active', updating); dom.cl.toggle('#buttonUpdate', 'disabled', - updating === false && - qs$('#lists .listEntry.checked.obsolete:not(.toRemove)') === null + updating === false && hasObsolete === false ); };