From 1e464ccb4ab675f6457949bc5304c606780c215d Mon Sep 17 00:00:00 2001 From: gorhill Date: Sun, 14 Sep 2014 18:23:12 -0400 Subject: [PATCH] code review --- js/messaging.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/js/messaging.js b/js/messaging.js index beaaf6ac8..e928cc961 100644 --- a/js/messaging.js +++ b/js/messaging.js @@ -201,8 +201,7 @@ var onDisconnect = function(port) { listener(msg, port.sender, nullFunc); // Cleanup port if no longer in use. - port = nameToPortMap[port.name]; - if ( port ) { + if ( nameToPortMap.hasOwnProperty(port.name) ) { delete nameToPortMap[port.name]; port.onMessage.removeListener(onMessage); port.onDisconnect.removeListener(onDisconnect);