From 13b7f381b23d447c8dd2cf2b073f0469efc3a434 Mon Sep 17 00:00:00 2001 From: Raymond Hill Date: Mon, 19 May 2025 16:55:27 -0400 Subject: [PATCH] [mv3] Safari: warn to not open filter issues for stable Safari Related issue: https://github.com/uBlockOrigin/uAssets/issues/28408 Stable Safari is known to not block certain network requests due to the current state of the DNR engine in Safari. The warning is to ensure volunteers are not burdened by issues originating from the browser. Eventually Safari's DNR implementation will catch up with the specification, at which time the warning will be removed. --- platform/mv3/extension/js/report.js | 1 + platform/mv3/extension/report.html | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/platform/mv3/extension/js/report.js b/platform/mv3/extension/js/report.js index c39c933ad..f3072c1a4 100644 --- a/platform/mv3/extension/js/report.js +++ b/platform/mv3/extension/js/report.js @@ -115,6 +115,7 @@ async function getConfigData() { } else { agent = 'Chrome'; } + dom.cl.add('html', agent.toLowerCase()); if ( /\bMobile\b/.test(navigator.userAgent) ) { agent += ' Mobile'; } diff --git a/platform/mv3/extension/report.html b/platform/mv3/extension/report.html index 0cb258ad9..5ebabe3ba 100644 --- a/platform/mv3/extension/report.html +++ b/platform/mv3/extension/report.html @@ -10,7 +10,8 @@ - + + @@ -18,6 +19,7 @@

+

Safari users: Please do not report filter issues at the moment. The declarativeNetRequest engine on stable version of Safari is not yet fully implemented as per specs. As a consequence this leads to many cases of network requests not being blocked.