prehistoric-systems/security-checklist
1
0
Fork 0
mirror of https://github.com/brianlovin/security-checklist.git synced 2026-03-11 08:55:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Move main app link to app name + icon to avoid nesting <a> inside <a>

Browse source
This commit is contained in:
Joachim Robert 2019-02-06 10:32:05 +01:00
parent 2d082b96a6
commit a8336bc5ce
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
components/ChecklistItem/App.js
View file

@ -38,8 +38,8 @@ export const AppRow = ({ app }: Props) => {
};
return (
<AppRowContainer href={app.url} target="_blank" rel="noopener noreferrer">
<AppMeta>
<AppRowContainer>
<AppMeta href={app.url} target="_blank" rel="noopener noreferrer" title={`go to: ${app.name}`}>
{app.image && <AppIcon alt={app.name} src={app.image} />}
<AppName>{app.name}</AppName>
</AppMeta>
@ -49,4 +49,4 @@ export const AppRow = ({ app }: Props) => {
{app.offer && <Offer offer={app.offer} />}
</AppRowContainer>
);
};
};

4
components/ChecklistItem/style.js
View file

@ -151,12 +151,12 @@ export const ResourceContent = styled.div`
export const AppsContainer = styled.div``;
export const AppMeta = styled.div`
export const AppMeta = styled.a`
display: flex;
align-items: center;
`;
export const AppRowContainer = styled.a`
export const AppRowContainer = styled.div`
display: flex;
justify-content: space-between;
align-items: center;