Add type="button" on buttons

This commit is contained in:
Joachim Robert 2019-02-06 15:02:13 +01:00
parent 8f6793348e
commit 08c8589d6d
3 changed files with 7 additions and 2 deletions

View file

@ -27,6 +27,7 @@ export default function CopyLinkButton(props: CopyLinkProps) {
data-cy="copy-link-button"
isClicked={isClicked}
aria-label="Copy the websites address to your clipboard."
type="button"
{...props}
>
<Icon glyph="link" size={24} />

View file

@ -75,7 +75,7 @@ export class Apps extends React.Component<Props, State> {
aria-expanded={overflowExpanded}
aria-controls={`apps_${resource.id}`}
>
<Button>Show {overflowExpanded ? "less" : "more"} choices</Button>
<Button type="button">Show {overflowExpanded ? "less" : "more"} choices</Button>
</ExpandContainer>
</React.Fragment>
)}

View file

@ -74,7 +74,11 @@ export default function Page(props: Props) {
<Header showHeaderShadow={showHeaderShadow} />
<InnerContainer>{children}</InnerContainer>
<Footer />
<ScrollToTop isVisible={scrollToTopVisible} onClick={scrollToTop}>
<ScrollToTop
isVisible={scrollToTopVisible}
onClick={scrollToTop}
type="button"
>
<Icon glyph="view-forward" size={32} />
</ScrollToTop>
</Container>