From d3fbd86dd3e26775b4abaf8a65efdfb6b7a76305 Mon Sep 17 00:00:00 2001
From: Christopher Gurnee <chris@gurneeconsulting.net>
Date: Fri, 13 May 2022 16:13:43 +0000
Subject: [PATCH] Rename redditIdsToPushshift() to fullnamesToShortIDs()

---
 src/pages/thread/index.js | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/src/pages/thread/index.js b/src/pages/thread/index.js
index b25175c..bfc082d 100644
--- a/src/pages/thread/index.js
+++ b/src/pages/thread/index.js
@@ -81,14 +81,15 @@ class Thread extends React.Component {
       console.warn("Can't merge contigs", this.curContig(), "and", nextContig)  // shouldn't happen
   }
 
-  redditIdsToPushshift (comment) {
+  // Convert Reddit fullnames to their short ID (base36) form
+  fullnamesToShortIDs (comment) {
     comment.parent_id = comment.parent_id?.substring(3) || this.props.match.params.threadID
     comment.link_id = comment.link_id?.substring(3)     || this.props.match.params.threadID
     return comment
   }
 
   // Can be called when a comment is missing from Pushshift;
-  // the comment's ids must have already been updated by redditIdsToPushshift()
+  // the comment's ids must have already been updated by fullnamesToShortIDs()
   useRedditComment (comment) {
     if (isRemoved(comment.body)) {
       this.state.removed++
@@ -225,7 +226,7 @@ class Thread extends React.Component {
       getRedditComments([commentID])
         .then(([comment]) => {
           if (comment)
-            this.redditIdsToPushshift(comment)
+            this.fullnamesToShortIDs(comment)
           if (comment?.link_id != threadID) {
             console.timeEnd('Load comments')
             this.props.global.setError({ message: 'Invalid permalink' })
@@ -321,13 +322,13 @@ class Thread extends React.Component {
               if (insertBefore == 0 || created_utc >= this.contigs[insertBefore - 1].lastCreated) {
                 this.contigs.splice(insertBefore, 0, {firstCreated: created_utc})
                 this.setCurContig(insertBefore)
-                this.redditIdsToPushshift(comment)
+                this.fullnamesToShortIDs(comment)
                 this.getComments(this.props.global.maxComments, false, comment)
 
               // Otherwise an earlier attempt to download it from Pushshift turned up nothing,
               } else {
                 const { pushshiftCommentLookup } = this.state
-                this.redditIdsToPushshift(comment)
+                this.fullnamesToShortIDs(comment)
                 this.useRedditComment(comment)       // so use the Reddit comment instead
                 this.setCurContig(insertBefore - 1)  // (this was the failed earlier attempt)
                 console.timeEnd('Load comments')
@@ -372,7 +373,7 @@ class Thread extends React.Component {
   //   persistent: if true, will try to continue downloading after the current contig has
   //               been completed and merged with the next contig.
   //  commentHint: a Reddit comment for use if Pushshift is missing that same comment;
-  //               its ids must have already been updated by redditIdsToPushshift()
+  //               its ids must have already been updated by fullnamesToShortIDs()
   getComments (newCommentCount, persistent = false, commentHint = undefined) {
     const { threadID, commentID } = this.props.match.params
     const { pushshiftCommentLookup } = this.state