Commit graph

1617 commits

Author SHA1 Message Date
Satindar Dhillon
c39ab2d5f7 retry article content fetches when server returns a .processing state 2022-05-02 20:30:57 -07:00
Jackson Harper
2c8a72d863
Merge pull request #528 from omnivore-app/dependabot/npm_and_yarn/nanoid-3.3.3
Bump nanoid from 3.3.1 to 3.3.3
2022-05-02 19:47:34 -07:00
Jackson Harper
b649d583b7 Linting changes 2022-05-02 15:58:40 -07:00
Jackson Harper
453b301e74 Allow looking up articles by ID
iOS needs to be able to lookup an article by its ID not its
slug, because the slug can change once saved.
2022-05-02 15:48:21 -07:00
Jackson Harper
fedd92488b
Merge pull request #491 from omnivore-app/OMN-423
[OMN-423] Updated share highlight modal
2022-05-02 15:28:02 -07:00
dependabot[bot]
98f028ac35
Bump nanoid from 3.3.1 to 3.3.3
Bumps [nanoid](https://github.com/ai/nanoid) from 3.3.1 to 3.3.3.
- [Release notes](https://github.com/ai/nanoid/releases)
- [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md)
- [Commits](https://github.com/ai/nanoid/compare/3.3.1...3.3.3)

---
updated-dependencies:
- dependency-name: nanoid
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-05-02 21:15:25 +00:00
Jackson Harper
3b3ec85117
Merge pull request #527 from omnivore-app/fix/font-stepper-ui
Use SVG images of grouped font stepper controls
2022-05-02 13:48:15 -07:00
Jackson Harper
deac4b6680 Use react attributes for SVG 2022-05-02 13:21:35 -07:00
Jackson Harper
039cab33ed Use embedded SVG so we can set colours 2022-05-02 13:01:50 -07:00
Jackson Harper
e865aa9a22
Merge pull request #524 from omnivore-app/fix/docker-api-build
We need node-gyp when building API in docker
2022-05-02 12:38:10 -07:00
Jackson Harper
9bdd7573c6 Story for the ReaderSettingsControl 2022-05-02 12:32:41 -07:00
Jackson Harper
93bd6b6ed5 Use SVG images of grouped font stepper controls
Aligning the components in CSS didn't work very
well, so this uses exported versions of the design
with the `A` icon and `+/-` symbol in a single image.
2022-05-02 12:19:37 -07:00
Satindar Dhillon
3cf0888c54 include pending linked when fetching 2022-05-02 11:13:10 -07:00
Satindar Dhillon
aa7d4247dd
Merge pull request #523 from omnivore-app/chore/update-swift-gql-schema
Update swift gql schema
2022-05-02 11:01:34 -07:00
Jackson Harper
9e94ed5067 We need node-gyp when building API in docker 2022-05-02 11:00:39 -07:00
Satindar Dhillon
938576693a update swift gql schema 2022-05-02 10:56:52 -07:00
Jackson Harper
aa3e91ac97
Merge pull request #522 from omnivore-app/fix/enable-local-introspection
Enable graphql introspection when running locally
2022-05-02 09:49:08 -07:00
Jackson Harper
61b7ac3cb2 Enable graphql introspection when running locally 2022-05-02 09:44:13 -07:00
Jackson Harper
834afe7877
Merge pull request #516 from omnivore-app/fix/non-user-events
Move the analytics event for link_read out of the container, supply userId
2022-04-29 14:51:13 -07:00
Jackson Harper
0c5c9f492a Move the analytics event for link_read out of the container, supply userId
This prevents events from being sent when there is no user id yet
due to race conditions in analytics setup.
2022-04-29 13:54:44 -07:00
Jackson Harper
ab421de20c
Merge pull request #515 from omnivore-app/fix/lazyloaded-srcset
Remove lazy loaded srcset elements
2022-04-29 10:46:04 -07:00
Jackson Harper
a24b976546 Remove lazy loaded srcset elements
Some tools like jetpack: https://jetpack.com/support/lazy-images/
use a temporary srcset element set to a data image when lazy
loading, these are later removed by JS. We test if there is
a valid src attribute and if the srcset attribute is a data embed
to remove these.
2022-04-29 10:05:33 -07:00
Jackson Harper
7f827dee55
Merge pull request #514 from omnivore-app/fix/description
Show empty description if not exist
2022-04-29 08:59:00 -07:00
Hongbo Wu
77ca0ceb59 Show empty description if not exist 2022-04-29 15:50:39 +08:00
Hongbo Wu
c089b74af9
Revert changes (#513)
* Revert "Remove includePending"

This reverts commit d9c58a6ee2.

* Revert "Remove state"

This reverts commit e2b6cadfda.

* Revert "Remove slug in articleSavingRequest"

This reverts commit 4502bece36.
2022-04-29 14:26:00 +08:00
Hongbo Wu
46aac8ac0a
Match the env var name (#512) 2022-04-29 14:10:56 +08:00
Jackson Harper
6bc3bd272a
Merge pull request #511 from omnivore-app/fix/remove-slug
Remove slug in articleSavingRequest
2022-04-28 23:01:06 -07:00
Hongbo Wu
4502bece36 Remove slug in articleSavingRequest 2022-04-29 13:59:47 +08:00
Jackson Harper
e2b6cadfda Remove state 2022-04-28 22:57:12 -07:00
Jackson Harper
d9c58a6ee2 Remove includePending 2022-04-28 22:47:13 -07:00
Hongbo Wu
2b70d480d2
Remove article saving request (#493)
* Add state and taskName in elastic page mappings

* Add state and taskName in elastic page interface

* Create page with PROCESSING state before scrapping

* Update createArticleRequest API

* Fix tests

* Add default state for pages

* Update createArticle API

* Update save page

* Update save file

* Update saving item description

* Show unable to parse content for failed page

* Fix date parsing

* Search for not failed pages

* Fix tests

* Add test for saveUrl

* Update get article saving request api

* Update get article test

* Add test for articleSavingRequest API

* Add test for failure

* Return new page id if clientRequestId empty

* Update clientRequestId in savePage

* Update clientRequestId in saveFile

* Replace article with slug in articleSavingRequest

* Add slug in articleSavingRequest response

* Depreciate article

* Use slug in web

* Remove article and highlight fragments

* Query article.slug on Prod

* Show unable to parse description for failed page

* Fix a bug having duplicate pages when saving the same url multiple times

* Add state in response

* Rename variables in removeArticle API

* Rename state

* Add state in response in web

* Make state an enum

* Open temporary page by link id

* Use an empty reader view as the background for loading pages

* Progressively load the article page as content is loaded

* Add includePending flag in getArticles API

* Set includePending = true in web

* Add elastic update mappings in migration script

* Add elastic mappings in docker image

* Move index_settings.json to migrate package

* Remove elastic index creation in api

* Move elastic migrations to a separate directory

* Remove index_settings from api docker image

Co-authored-by: Jackson Harper <jacksonh@gmail.com>
2022-04-29 13:41:06 +08:00
Satindar Dhillon
170b7d9144
Merge pull request #505 from omnivore-app/chore/more-async
Offline PDF Support + Async conversions
2022-04-28 21:34:37 -07:00
Satindar Dhillon
1a4c0ab76e add back onSave handler for applied labels 2022-04-28 20:26:12 -07:00
Hongbo Wu
ccb79845bc
Fix subscriptions issues (#501)
* Replace fetch with axios

* Add url in subscription

* Remove url in subscription

* Unsubscribe all newsletters before deleting that email

* Continue unsubscribing others if one got error
2022-04-29 11:16:46 +08:00
dependabot[bot]
e9522e8454
Bump cross-fetch from 3.1.4 to 3.1.5
Bumps [cross-fetch](https://github.com/lquixada/cross-fetch) from 3.1.4 to 3.1.5.
- [Release notes](https://github.com/lquixada/cross-fetch/releases)
- [Commits](https://github.com/lquixada/cross-fetch/compare/v3.1.4...v3.1.5)

---
updated-dependencies:
- dependency-name: cross-fetch
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-04-29 01:15:08 +00:00
Satindar Dhillon
44fe6b4ef7 register segment user when app is launched 2022-04-28 16:29:22 -07:00
Satindar Dhillon
44bfa600b9 track app lifecycle events with segment 2022-04-28 15:33:16 -07:00
Satindar Dhillon
6f12941e32 udpate macos pdfviewer call 2022-04-28 15:01:05 -07:00
Satindar Dhillon
29c6193bda set pdf data in local document and pass that url to pspdfkit 2022-04-28 14:58:46 -07:00
Satindar Dhillon
8b71188a26 fetch and store pdf data in core data 2022-04-28 13:57:02 -07:00
Satindar Dhillon
ffe1eed6b6 remove extra combine imports 2022-04-28 12:49:06 -07:00
Satindar Dhillon
ffdcb605c7 use async urlsession func to submit google token 2022-04-28 12:49:06 -07:00
Satindar Dhillon
6e0879c34c remove combine code from async image 2022-04-28 12:49:06 -07:00
Satindar Dhillon
4d887b3505
Merge pull request #507 from omnivore-app/feature/ios-segment-integration
iOS Segment Integration
2022-04-28 12:46:47 -07:00
Satindar Dhillon
d7acfe69f8 track link read events 2022-04-28 11:44:18 -07:00
Satindar Dhillon
b317e1b96b set the writeKey on segment config 2022-04-28 10:21:16 -07:00
Satindar Dhillon
30dcae7c10 remove comment 2022-04-28 10:11:43 -07:00
Satindar Dhillon
0a35393f57 add trackableEvents file 2022-04-28 10:04:53 -07:00
Satindar Dhillon
598b3a6000 add segment integration and wrapper class to track events 2022-04-28 10:04:34 -07:00
Satindar Dhillon
5c155e1cd6
Merge pull request #502 from omnivore-app/feature/labels-syncing
Labels syncing
2022-04-27 21:12:32 -07:00