Commit graph

757 commits

Author SHA1 Message Date
Jackson Harper
08e14c7577 Fix parsing of video IDs out of shared YouTube URLs 2022-05-04 10:45:16 -07:00
Jackson Harper
400a62b9f4
Merge pull request #396 from omnivore-app/feature/search-highlights-web
Feature/search highlights web
2022-05-04 09:11:38 -07:00
Hongbo Wu
8f60a9f905 Add default state to migration script 2022-05-04 21:54:28 +08:00
Hongbo Wu
21ff9a5ae7 Add test for state=failed or processing 2022-05-04 21:42:59 +08:00
Hongbo Wu
93ab6bc87a Add includePending=true in search API 2022-05-04 21:28:06 +08:00
Hongbo Wu
bc1ed3f054 Check state in articleSavingRequest 2022-05-04 19:33:13 +08:00
Hongbo Wu
9e3db0e053 Fix a bug to have multiple pages with the same url in lib 2022-05-04 19:12:22 +08:00
Hongbo Wu
afe8b6e948 make savedAt a required field in page 2022-05-04 17:54:59 +08:00
Hongbo Wu
0bff046733 Revert "Replace getArticleSavingRequest with getArticle"
This reverts commit cf65a63532.
2022-05-04 17:43:37 +08:00
Hongbo Wu
cf65a63532 Replace getArticleSavingRequest with getArticle 2022-05-04 14:30:54 +08:00
Jackson Harper
cab784b68b Remove debug 2022-05-03 22:09:43 -07:00
Hongbo Wu
a42bb7ab38 Replace createdAt with savedAt 2022-05-04 12:59:07 +08:00
Hongbo Wu
98ea1016d5 Remove <p> tag in description 2022-05-04 12:50:22 +08:00
Hongbo Wu
9048ccbab3 Show failed pages in library 2022-05-04 12:46:57 +08:00
Hongbo Wu
0b0100f0e5 Revert web change 2022-05-04 12:25:10 +08:00
Hongbo Wu
ca0f58ee22 Update page content and state if failed to parse 2022-05-04 12:21:41 +08:00
Hongbo Wu
2aa0618d28 Use id instead of slug 2022-05-04 12:16:21 +08:00
Hongbo Wu
329efacbe5 Redirect to slug page 2022-05-04 12:12:20 +08:00
Hongbo Wu
80d0146f72 Show unable to parse if page is failed to save within 30 seconds 2022-05-04 11:55:16 +08:00
Jackson Harper
8a7389712b Pull scroll to highlight changes into this branch 2022-05-03 15:00:49 -07:00
Jackson Harper
c5549d72a6 Pull in link to highlight changes 2022-05-03 14:04:40 -07:00
Jackson Harper
5d42b65611 Remove unused import 2022-05-03 12:15:57 -07:00
Jackson Harper
5ea67a0bea Pull in new highlight cards 2022-05-03 12:09:32 -07:00
Jackson Harper
bbb812f196 Rebase 2022-05-03 11:08:02 -07:00
Hongbo Wu
f68507c069 add sort by updated and recently read 2022-05-03 11:04:01 -07:00
Hongbo Wu
b36e8a78d7 remove luxon dependency in web 2022-05-03 11:03:59 -07:00
Hongbo Wu
5eff1c05bf add savedAt and publishedAt date range in search query 2022-05-03 11:03:39 -07:00
Hongbo Wu
6061f2927b update web to call new search endpoint for pages 2022-05-03 11:02:41 -07:00
Jackson Harper
c8c4377346
Merge pull request #531 from omnivore-app/fix/saving-analytics
Add more detailed analytics for saving. Remove intercom events
2022-05-02 21:14:18 -07:00
Jackson Harper
95b163a437 Prettier clean up 2022-05-02 20:58:05 -07:00
Jackson Harper
ab96bb09ab Add more detailed analytics for saving. Remove intercom events 2022-05-02 20:41:10 -07:00
Jackson Harper
b649d583b7 Linting changes 2022-05-02 15:58:40 -07:00
Jackson Harper
453b301e74 Allow looking up articles by ID
iOS needs to be able to lookup an article by its ID not its
slug, because the slug can change once saved.
2022-05-02 15:48:21 -07:00
Jackson Harper
fedd92488b
Merge pull request #491 from omnivore-app/OMN-423
[OMN-423] Updated share highlight modal
2022-05-02 15:28:02 -07:00
Jackson Harper
3b3ec85117
Merge pull request #527 from omnivore-app/fix/font-stepper-ui
Use SVG images of grouped font stepper controls
2022-05-02 13:48:15 -07:00
Jackson Harper
deac4b6680 Use react attributes for SVG 2022-05-02 13:21:35 -07:00
Jackson Harper
039cab33ed Use embedded SVG so we can set colours 2022-05-02 13:01:50 -07:00
Jackson Harper
9bdd7573c6 Story for the ReaderSettingsControl 2022-05-02 12:32:41 -07:00
Jackson Harper
93bd6b6ed5 Use SVG images of grouped font stepper controls
Aligning the components in CSS didn't work very
well, so this uses exported versions of the design
with the `A` icon and `+/-` symbol in a single image.
2022-05-02 12:19:37 -07:00
Jackson Harper
9e94ed5067 We need node-gyp when building API in docker 2022-05-02 11:00:39 -07:00
Jackson Harper
61b7ac3cb2 Enable graphql introspection when running locally 2022-05-02 09:44:13 -07:00
Jackson Harper
0c5c9f492a Move the analytics event for link_read out of the container, supply userId
This prevents events from being sent when there is no user id yet
due to race conditions in analytics setup.
2022-04-29 13:54:44 -07:00
Jackson Harper
a24b976546 Remove lazy loaded srcset elements
Some tools like jetpack: https://jetpack.com/support/lazy-images/
use a temporary srcset element set to a data image when lazy
loading, these are later removed by JS. We test if there is
a valid src attribute and if the srcset attribute is a data embed
to remove these.
2022-04-29 10:05:33 -07:00
Hongbo Wu
77ca0ceb59 Show empty description if not exist 2022-04-29 15:50:39 +08:00
Hongbo Wu
c089b74af9
Revert changes (#513)
* Revert "Remove includePending"

This reverts commit d9c58a6ee2.

* Revert "Remove state"

This reverts commit e2b6cadfda.

* Revert "Remove slug in articleSavingRequest"

This reverts commit 4502bece36.
2022-04-29 14:26:00 +08:00
Hongbo Wu
46aac8ac0a
Match the env var name (#512) 2022-04-29 14:10:56 +08:00
Hongbo Wu
4502bece36 Remove slug in articleSavingRequest 2022-04-29 13:59:47 +08:00
Jackson Harper
e2b6cadfda Remove state 2022-04-28 22:57:12 -07:00
Jackson Harper
d9c58a6ee2 Remove includePending 2022-04-28 22:47:13 -07:00
Hongbo Wu
2b70d480d2
Remove article saving request (#493)
* Add state and taskName in elastic page mappings

* Add state and taskName in elastic page interface

* Create page with PROCESSING state before scrapping

* Update createArticleRequest API

* Fix tests

* Add default state for pages

* Update createArticle API

* Update save page

* Update save file

* Update saving item description

* Show unable to parse content for failed page

* Fix date parsing

* Search for not failed pages

* Fix tests

* Add test for saveUrl

* Update get article saving request api

* Update get article test

* Add test for articleSavingRequest API

* Add test for failure

* Return new page id if clientRequestId empty

* Update clientRequestId in savePage

* Update clientRequestId in saveFile

* Replace article with slug in articleSavingRequest

* Add slug in articleSavingRequest response

* Depreciate article

* Use slug in web

* Remove article and highlight fragments

* Query article.slug on Prod

* Show unable to parse description for failed page

* Fix a bug having duplicate pages when saving the same url multiple times

* Add state in response

* Rename variables in removeArticle API

* Rename state

* Add state in response in web

* Make state an enum

* Open temporary page by link id

* Use an empty reader view as the background for loading pages

* Progressively load the article page as content is loaded

* Add includePending flag in getArticles API

* Set includePending = true in web

* Add elastic update mappings in migration script

* Add elastic mappings in docker image

* Move index_settings.json to migrate package

* Remove elastic index creation in api

* Move elastic migrations to a separate directory

* Remove index_settings from api docker image

Co-authored-by: Jackson Harper <jacksonh@gmail.com>
2022-04-29 13:41:06 +08:00