prehistoric-systems/omnivore
1
0
Fork 0
mirror of https://github.com/omnivore-app/omnivore.git synced 2026-03-11 08:54:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #3912 from omnivore-app/fix/digest

Browse source 
catch db error in digest job and only send notifications when digest created
This commit is contained in:
Hongbo Wu 2024-05-07 19:29:35 +08:00 committed by GitHub
commit fe3aeb6d27
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 34 additions and 36 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

70
packages/api/src/jobs/ai/create_digest.ts
View file

@ -637,35 +637,29 @@ export const createDigest = async (jobData: CreateDigestData) => {
// generate a unique id for the digest if not provided for scheduled jobs
const digestId = jobData.id ?? uuid()
const user = await findUserAndPersonalization(jobData.userId)
if (!user) {
logger.error('User not found', { userId: jobData.userId })
return writeDigest(jobData.userId, {
id: digestId,
jobState: TaskState.Failed,
})
}
const personalization = user.userPersonalization
if (!personalization) {
logger.info('User personalization not found')
}
const config = personalization
? (personalization.digestConfig as {
model?: string
channels?: Channel[]
})
: undefined
// default digest
let digest: Digest = {
id: digestId,
jobState: TaskState.Succeeded,
}
let filteredSummaries: RankedItem[] = []
try {
const user = await findUserAndPersonalization(jobData.userId)
if (!user) {
logger.error('User not found', { userId: jobData.userId })
return await writeDigest(jobData.userId, {
id: digestId,
jobState: TaskState.Failed,
title: 'User not found',
})
}
const personalization = user.userPersonalization
if (!personalization) {
logger.info('User personalization not found')
}
const config = personalization
? (personalization.digestConfig as {
model?: string
channels?: Channel[]
})
: undefined
digestDefinition = await fetchDigestDefinition()
const model = selectModel(config?.model || digestDefinition.model)
logger.info(`model: ${model}`)
@ -676,7 +670,11 @@ export const createDigest = async (jobData: CreateDigestData) => {
)
if (candidates.length === 0) {
logger.info('No candidates found')
return writeDigest(jobData.userId, digest)
return await writeDigest(jobData.userId, {
id: digestId,
jobState: TaskState.Failed,
title: 'No candidates found',
})
}
// const userProfile = await findOrCreateUserProfile(jobData.userId)
@ -693,7 +691,7 @@ export const createDigest = async (jobData: CreateDigestData) => {
const summaries = await summarizeItems(model, selections)
console.timeEnd('summarizeItems')
filteredSummaries = filterSummaries(summaries)
const filteredSummaries = filterSummaries(summaries)
const speechFiles = generateSpeechFiles(filteredSummaries, {
...jobData,
@ -701,7 +699,7 @@ export const createDigest = async (jobData: CreateDigestData) => {
secondaryVoice: jobData.voices?.[1],
})
const title = generateTitle(filteredSummaries)
digest = {
const digest = {
id: digestId,
title,
content: generateContent(filteredSummaries),
@ -732,6 +730,11 @@ export const createDigest = async (jobData: CreateDigestData) => {
])
logger.info(`digest created: ${digest.id}`)
// send notifications when digest is created
await sendNotifications(user, digest, filteredSummaries, config?.channels)
console.timeEnd('createDigestJob')
} catch (error) {
logger.error('createDigestJob error', error)
@ -740,10 +743,5 @@ export const createDigest = async (jobData: CreateDigestData) => {
jobState: TaskState.Failed,
title: 'Failed to create digest',
})
} finally {
// send notification
await sendNotifications(user, digest, filteredSummaries, config?.channels)
console.timeEnd('createDigestJob')
}
}