prehistoric-systems/omnivore
1
0
Fork 0
mirror of https://github.com/omnivore-app/omnivore.git synced 2026-03-11 08:54:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

use string rather than boolean to send js event

Browse source
This commit is contained in:
Satindar Dhillon 2023-02-09 17:55:48 -08:00
parent eddbcd293a
commit fc49c54867
4 changed files with 5 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
android/Omnivore/app/src/main/assets/bundle.js
View file

File diff suppressed because one or more lines are too long

2
apple/OmnivoreKit/Sources/Views/Article/OmnivoreWebView.swift
View file

@ -505,7 +505,7 @@ public enum WebViewDispatchEvent {
case .annotate, .highlight, .setHighlightLabels, .share, .remove, .copyHighlight, .dismissHighlight:
return ""
case let .handleAutoHighlightModeChange(isEnabled: isEnabled):
return "event.enableHighlightOnRelease = '\(isEnabled)';"
return "event.enableHighlightOnRelease = '\(isEnabled ? "on" : "off")';"
}
}
}

2
apple/OmnivoreKit/Sources/Views/Resources/bundle.js
View file

File diff suppressed because one or more lines are too long

7
packages/web/components/templates/article/ArticleContainer.tsx
View file

@ -151,14 +151,11 @@ export function ArticleContainer(props: ArticleContainerProps): JSX.Element {
}
interface UpdateHighlightModeEvent extends Event {
enableHighlightOnRelease?: boolean
enableHighlightOnRelease?: string
}
const updateHighlightMode = (event: UpdateHighlightModeEvent) => {
const isEnabled =
event.enableHighlightOnRelease !== undefined
? event.enableHighlightOnRelease
: false
const isEnabled = event.enableHighlightOnRelease === 'on'
setHighlightOnRelease(isEnabled)
}