From f54968d5d12d7b55082fcaaa4a2088f954a7cc9a Mon Sep 17 00:00:00 2001
From: Jackson Harper <jacksonh@gmail.com>
Date: Thu, 2 Jun 2022 21:36:28 -0700
Subject: [PATCH] Fixes for the sync state UI when errors occur

If syncing fails, the item is still saved so we don't change the
title.

When syncing fails make sure the red error cloud is shown.
---
 .../App/AppExtensions/Share/ExtensionSaveService.swift        | 4 ++--
 apple/OmnivoreKit/Sources/Views/ShareExtensionView.swift      | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/apple/OmnivoreKit/Sources/App/AppExtensions/Share/ExtensionSaveService.swift b/apple/OmnivoreKit/Sources/App/AppExtensions/Share/ExtensionSaveService.swift
index 943dd94ec..e527cae64 100644
--- a/apple/OmnivoreKit/Sources/App/AppExtensions/Share/ExtensionSaveService.swift
+++ b/apple/OmnivoreKit/Sources/App/AppExtensions/Share/ExtensionSaveService.swift
@@ -166,12 +166,12 @@ class ExtensionSaveService {
         }
 
       } catch {
-        print("ERROR SYNCING", error)
         updateStatus(newStatus: .syncFailed(error: SaveArticleError.unknown(description: "Unknown Error")))
+        return
       }
 
-      state = .finished
       updateStatus(newStatus: .synced)
+      state = .finished
     }
   }
 }
diff --git a/apple/OmnivoreKit/Sources/Views/ShareExtensionView.swift b/apple/OmnivoreKit/Sources/Views/ShareExtensionView.swift
index 14f25c748..591850b07 100644
--- a/apple/OmnivoreKit/Sources/Views/ShareExtensionView.swift
+++ b/apple/OmnivoreKit/Sources/Views/ShareExtensionView.swift
@@ -156,11 +156,11 @@ public struct ShareExtensionChildView: View {
 
   private var titleText: String {
     switch viewModel.status {
-    case .saved, .synced:
+    case .saved, .synced, .syncFailed(error: _):
       return "Saved to Omnivore"
     case .processing:
       return "Saving to Omnivore"
-    default:
+    case .failed(error: _):
       return "Error saving to Omnivore"
     }
   }