prehistoric-systems/omnivore
1
0
Fork 0
mirror of https://github.com/omnivore-app/omnivore.git synced 2026-03-11 08:54:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Stop throwing document not found exception to sentry

Browse source
This commit is contained in:
Hongbo Wu 2022-05-13 11:40:08 +08:00
parent 394a558e45
commit f51dbafdfc
3 changed files with 36 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
packages/api/src/elastic/highlights.ts
View file

@ -289,13 +289,6 @@ export const updateHighlight = async (
return true
} catch (e) {
if (
e instanceof ResponseError &&
e.message === 'document_missing_exception'
) {
console.log('page has been deleted')
return false
}
console.error('failed to update highlight in elastic', e)
return false
}

15
packages/api/src/elastic/labels.ts
View file

@ -1,6 +1,7 @@
import { Label, PageContext } from './types'
import { client, INDEX_ALIAS } from './index'
import { EntityType } from '../datalayer/pubsub'
import { ResponseError } from '@elastic/elasticsearch/lib/errors'
export const addLabelInPage = async (
pageId: string,
@ -38,6 +39,13 @@ export const addLabelInPage = async (
return true
} catch (e) {
if (
e instanceof ResponseError &&
e.message === 'document_missing_exception'
) {
console.log('page has been deleted', pageId)
return false
}
console.error('failed to add a label in elastic', e)
return false
}
@ -74,6 +82,13 @@ export const updateLabelsInPage = async (
return true
} catch (e) {
if (
e instanceof ResponseError &&
e.message === 'document_missing_exception'
) {
console.log('page has been deleted', pageId)
return false
}
console.error('failed to update labels in elastic', e)
return false
}

23
packages/api/src/elastic/pages.ts
View file

@ -21,6 +21,7 @@ import {
} from '../utils/search'
import { client, INDEX_ALIAS } from './index'
import { EntityType } from '../datalayer/pubsub'
import { ResponseError } from '@elastic/elasticsearch/lib/errors'
const appendQuery = (body: SearchBody, query: string): void => {
body.query.bool.should.push({
@ -237,6 +238,13 @@ export const updatePage = async (
return true
} catch (e) {
if (
e instanceof ResponseError &&
e.message === 'document_missing_exception'
) {
console.log('page has been deleted', id)
return false
}
console.error('failed to update a page in elastic', e)
return false
}
@ -259,6 +267,13 @@ export const deletePage = async (
return true
} catch (e) {
if (
e instanceof ResponseError &&
e.message === 'document_missing_exception'
) {
console.log('page has been deleted', id)
return false
}
console.error('failed to delete a page in elastic', e)
return false
}
@ -300,7 +315,7 @@ export const getPageByParam = async <K extends keyof ParamSet>(
id: body.hits.hits[0]._id,
} as Page
} catch (e) {
console.error('failed to search pages in elastic', e)
console.error('failed to get pages by param in elastic', e)
return undefined
}
}
@ -317,7 +332,11 @@ export const getPageById = async (id: string): Promise<Page | undefined> => {
id: body._id as string,
} as Page
} catch (e) {
console.error('failed to search pages in elastic', e)
if (e instanceof ResponseError && e.statusCode === 404) {
console.log('page has been deleted', id)
return undefined
}
console.error('failed to get page by id in elastic', e)
return undefined
}
}