From 25842270d7812dd944d9668471b7a124d2c60966 Mon Sep 17 00:00:00 2001 From: Hongbo Wu Date: Tue, 13 Dec 2022 12:04:17 +0800 Subject: [PATCH 1/3] Update the rule to only trigger on page created event --- packages/api/src/services/groups.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/api/src/services/groups.ts b/packages/api/src/services/groups.ts index 2776ef89a..9e65b164f 100644 --- a/packages/api/src/services/groups.ts +++ b/packages/api/src/services/groups.ts @@ -254,6 +254,6 @@ export const createLabelAndRuleForGroup = async ( ], }, ], - filter: `recommendedBy:"${groupName}"`, + filter: `event:created recommendedBy:"${groupName}"`, }) } From 918ada2100f160cc33640487f7eb87ef1a8ed9be Mon Sep 17 00:00:00 2001 From: Hongbo Wu Date: Tue, 13 Dec 2022 12:12:20 +0800 Subject: [PATCH 2/3] only recommend highlights created by the user --- packages/api/src/resolvers/recommendations/index.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/api/src/resolvers/recommendations/index.ts b/packages/api/src/resolvers/recommendations/index.ts index 72e7c5043..d2fed1092 100644 --- a/packages/api/src/resolvers/recommendations/index.ts +++ b/packages/api/src/resolvers/recommendations/index.ts @@ -204,8 +204,9 @@ export const recommendResolver = authorized< } } + // only recommend highlights created by the user const recommendedHighlightIds = input.recommendedWithHighlights - ? page.highlights?.map((h) => h.id) + ? page.highlights?.filter((h) => h.userId === uid)?.map((h) => h.id) : undefined const exp = Math.floor(Date.now() / 1000) + 60 * 60 * 24 // 1 day From a3406992402b7c8504d5ad0e9378894a02945d3b Mon Sep 17 00:00:00 2001 From: Hongbo Wu Date: Tue, 13 Dec 2022 12:15:41 +0800 Subject: [PATCH 3/3] add comment --- packages/api/src/services/groups.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/api/src/services/groups.ts b/packages/api/src/services/groups.ts index 9e65b164f..73454c0a5 100644 --- a/packages/api/src/services/groups.ts +++ b/packages/api/src/services/groups.ts @@ -254,6 +254,7 @@ export const createLabelAndRuleForGroup = async ( ], }, ], + // add a condition to check if the page is created filter: `event:created recommendedBy:"${groupName}"`, }) }