From f372636d6e9ebc369f60ac28ae0524f7886b9cb8 Mon Sep 17 00:00:00 2001
From: Hongbo Wu <hongbo@omnivore.app>
Date: Tue, 27 Jun 2023 16:47:36 +0800
Subject: [PATCH] fix: tweet not saved correctly when using share button on iOS

---
 packages/api/src/services/save_page.ts | 35 +++++++++++++-------------
 1 file changed, 18 insertions(+), 17 deletions(-)

diff --git a/packages/api/src/services/save_page.ts b/packages/api/src/services/save_page.ts
index c58ded776..e45fba331 100644
--- a/packages/api/src/services/save_page.ts
+++ b/packages/api/src/services/save_page.ts
@@ -117,7 +117,24 @@ export const savePage = async (
     ? await createLabels(ctx, input.labels)
     : undefined
 
-  if (existingPage) {
+  // always parse in backend if the url is in the force puppeteer list
+  if (shouldParseInBackend(input)) {
+    try {
+      await createPageSaveRequest({
+        userId: saver.userId,
+        url: articleToSave.url,
+        pubsub: ctx.pubsub,
+        articleSavingRequestId: input.clientRequestId,
+        archivedAt: articleToSave.archivedAt,
+        labels: articleToSave.labels,
+      })
+    } catch (e) {
+      return {
+        errorCodes: [SaveErrorCode.Unknown],
+        message: 'Failed to create page save request',
+      }
+    }
+  } else if (existingPage) {
     pageId = existingPage.id
     slug = existingPage.slug
     if (
@@ -138,22 +155,6 @@ export const savePage = async (
         message: 'Failed to update existing page',
       }
     }
-  } else if (shouldParseInBackend(input)) {
-    try {
-      await createPageSaveRequest({
-        userId: saver.userId,
-        url: articleToSave.url,
-        pubsub: ctx.pubsub,
-        articleSavingRequestId: input.clientRequestId,
-        archivedAt: articleToSave.archivedAt,
-        labels: articleToSave.labels,
-      })
-    } catch (e) {
-      return {
-        errorCodes: [SaveErrorCode.Unknown],
-        message: 'Failed to create page save request',
-      }
-    }
   } else {
     const newPageId = await createPage(articleToSave, ctx)
     if (!newPageId) {