From 53c4fc835d27e2dec97abd746b4051049fecf591 Mon Sep 17 00:00:00 2001 From: Hongbo Wu Date: Tue, 5 Apr 2022 16:16:04 +0800 Subject: [PATCH 01/18] debug github action --- packages/api/mocha-config.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/api/mocha-config.json b/packages/api/mocha-config.json index b7a0e4f93..ee206ab32 100644 --- a/packages/api/mocha-config.json +++ b/packages/api/mocha-config.json @@ -1,5 +1,5 @@ { "extension": ["ts"], - "spec": "test/**/*.test.ts", + "spec": "test/elastic/*.test.ts", "require": ["test/babel-register.js", "test/global-setup.ts", "test/global-teardown.ts"] } From 02c4afd19686a20a39c8a91238080c37d28199c3 Mon Sep 17 00:00:00 2001 From: Hongbo Wu Date: Tue, 5 Apr 2022 16:19:12 +0800 Subject: [PATCH 02/18] add failed test --- packages/api/test/elastic/index.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/api/test/elastic/index.test.ts b/packages/api/test/elastic/index.test.ts index 29e86d07d..820f8ffd7 100644 --- a/packages/api/test/elastic/index.test.ts +++ b/packages/api/test/elastic/index.test.ts @@ -106,7 +106,7 @@ describe('elastic api', () => { url: page.url, }) - expect(pageFound).not.undefined + expect(pageFound).to.undefined }) }) From c6778f307acb7264c1f023a21b25bfdfb37fb091 Mon Sep 17 00:00:00 2001 From: Hongbo Wu Date: Tue, 5 Apr 2022 16:29:39 +0800 Subject: [PATCH 03/18] test all --- packages/api/mocha-config.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/api/mocha-config.json b/packages/api/mocha-config.json index ee206ab32..b7a0e4f93 100644 --- a/packages/api/mocha-config.json +++ b/packages/api/mocha-config.json @@ -1,5 +1,5 @@ { "extension": ["ts"], - "spec": "test/elastic/*.test.ts", + "spec": "test/**/*.test.ts", "require": ["test/babel-register.js", "test/global-setup.ts", "test/global-teardown.ts"] } From ed76093c402c59c4d1e13a554862568f93a42ccb Mon Sep 17 00:00:00 2001 From: Hongbo Wu Date: Tue, 5 Apr 2022 16:40:41 +0800 Subject: [PATCH 04/18] continue on error in github action --- .github/workflows/run-tests.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/run-tests.yaml b/.github/workflows/run-tests.yaml index 16aab9ebb..71dd1c077 100644 --- a/.github/workflows/run-tests.yaml +++ b/.github/workflows/run-tests.yaml @@ -69,6 +69,7 @@ jobs: yarn build yarn lint yarn test + continue-on-error: true env: PG_HOST: localhost PG_PORT: ${{ job.services.postgres.ports[5432] }} @@ -85,4 +86,4 @@ jobs: with: fetch-depth: 0 - name: Build the API docker image - run: 'docker build --file packages/api/Dockerfile .' \ No newline at end of file + run: 'docker build --file packages/api/Dockerfile .' From a2dc73b3c0a3967ab7126327ff9d259df873da68 Mon Sep 17 00:00:00 2001 From: Hongbo Wu Date: Tue, 5 Apr 2022 16:49:14 +0800 Subject: [PATCH 05/18] make a separate step for testing --- .github/workflows/run-tests.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/run-tests.yaml b/.github/workflows/run-tests.yaml index 71dd1c077..c3f83fd31 100644 --- a/.github/workflows/run-tests.yaml +++ b/.github/workflows/run-tests.yaml @@ -63,13 +63,13 @@ jobs: run: | source ~/.nvm/nvm.sh yarn install --frozen-lockfile - - name: TypeScript, Lint, Tests + - name: TypeScript, Lint run: | source ~/.nvm/nvm.sh yarn build yarn lint - yarn test - continue-on-error: true + - name: Tests + run: yarn test env: PG_HOST: localhost PG_PORT: ${{ job.services.postgres.ports[5432] }} From 8db808c1103d9c10111a8946aa55b4752f439e05 Mon Sep 17 00:00:00 2001 From: Hongbo Wu Date: Tue, 5 Apr 2022 17:05:15 +0800 Subject: [PATCH 06/18] test running services --- .github/workflows/run-tests.yaml | 5 ++--- packages/api/mocha-config.json | 2 +- packages/api/test/elastic/index.test.ts | 2 +- packages/api/test/services/create_user.test.ts | 2 +- 4 files changed, 5 insertions(+), 6 deletions(-) diff --git a/.github/workflows/run-tests.yaml b/.github/workflows/run-tests.yaml index c3f83fd31..c470508b6 100644 --- a/.github/workflows/run-tests.yaml +++ b/.github/workflows/run-tests.yaml @@ -63,13 +63,12 @@ jobs: run: | source ~/.nvm/nvm.sh yarn install --frozen-lockfile - - name: TypeScript, Lint + - name: TypeScript, Lint, Tests run: | source ~/.nvm/nvm.sh yarn build yarn lint - - name: Tests - run: yarn test + yarn test env: PG_HOST: localhost PG_PORT: ${{ job.services.postgres.ports[5432] }} diff --git a/packages/api/mocha-config.json b/packages/api/mocha-config.json index b7a0e4f93..eb6f3dcf8 100644 --- a/packages/api/mocha-config.json +++ b/packages/api/mocha-config.json @@ -1,5 +1,5 @@ { "extension": ["ts"], - "spec": "test/**/*.test.ts", + "spec": "test/services/*.test.ts", "require": ["test/babel-register.js", "test/global-setup.ts", "test/global-teardown.ts"] } diff --git a/packages/api/test/elastic/index.test.ts b/packages/api/test/elastic/index.test.ts index 820f8ffd7..29e86d07d 100644 --- a/packages/api/test/elastic/index.test.ts +++ b/packages/api/test/elastic/index.test.ts @@ -106,7 +106,7 @@ describe('elastic api', () => { url: page.url, }) - expect(pageFound).to.undefined + expect(pageFound).not.undefined }) }) diff --git a/packages/api/test/services/create_user.test.ts b/packages/api/test/services/create_user.test.ts index b5081679f..4478d9d6d 100644 --- a/packages/api/test/services/create_user.test.ts +++ b/packages/api/test/services/create_user.test.ts @@ -33,7 +33,7 @@ describe('create a user with an invite', () => { expect(await getUserFollowers(user)).to.eql([adminUser]) expect(await getUserFollowing(user)).to.eql([adminUser]) expect(await getUserFollowers(adminUser)).to.eql([user]) - expect(await getUserFollowing(adminUser)).to.eql([user]) + expect(await getUserFollowing(adminUser)).not.to.eql([user]) }).timeout(10000) it('creates profile when user exists but profile not', async () => { From a203e0776e2e130ca193bee8d0312ca157c20e81 Mon Sep 17 00:00:00 2001 From: Hongbo Wu Date: Tue, 5 Apr 2022 17:17:03 +0800 Subject: [PATCH 07/18] test a single service --- packages/api/mocha-config.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/api/mocha-config.json b/packages/api/mocha-config.json index eb6f3dcf8..576d523b7 100644 --- a/packages/api/mocha-config.json +++ b/packages/api/mocha-config.json @@ -1,5 +1,5 @@ { "extension": ["ts"], - "spec": "test/services/*.test.ts", + "spec": "test/services/create_user.test.ts", "require": ["test/babel-register.js", "test/global-setup.ts", "test/global-teardown.ts"] } From ec2a63344678314a3d6a1d54632fab14ef70247c Mon Sep 17 00:00:00 2001 From: Hongbo Wu Date: Tue, 5 Apr 2022 17:27:13 +0800 Subject: [PATCH 08/18] test a single resolver --- packages/api/mocha-config.json | 2 +- packages/api/test/resolvers/article.test.ts | 4 +++- packages/api/test/services/create_user.test.ts | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/packages/api/mocha-config.json b/packages/api/mocha-config.json index 576d523b7..2fd06093c 100644 --- a/packages/api/mocha-config.json +++ b/packages/api/mocha-config.json @@ -1,5 +1,5 @@ { "extension": ["ts"], - "spec": "test/services/create_user.test.ts", + "spec": "test/resolvers/article.test.ts", "require": ["test/babel-register.js", "test/global-setup.ts", "test/global-teardown.ts"] } diff --git a/packages/api/test/resolvers/article.test.ts b/packages/api/test/resolvers/article.test.ts index 1dad82e7a..fab47aab8 100644 --- a/packages/api/test/resolvers/article.test.ts +++ b/packages/api/test/resolvers/article.test.ts @@ -294,7 +294,9 @@ describe('Article API', () => { it('should create an article', async () => { const res = await graphqlRequest(query, authToken).expect(200) - expect(res.body.data.createArticle.createdArticle.title).to.eql(title) + expect(res.body.data.createArticle.createdArticle.title).not.to.eql( + title + ) pageId = res.body.data.createArticle.createdArticle.id }) }) diff --git a/packages/api/test/services/create_user.test.ts b/packages/api/test/services/create_user.test.ts index 4478d9d6d..b5081679f 100644 --- a/packages/api/test/services/create_user.test.ts +++ b/packages/api/test/services/create_user.test.ts @@ -33,7 +33,7 @@ describe('create a user with an invite', () => { expect(await getUserFollowers(user)).to.eql([adminUser]) expect(await getUserFollowing(user)).to.eql([adminUser]) expect(await getUserFollowers(adminUser)).to.eql([user]) - expect(await getUserFollowing(adminUser)).not.to.eql([user]) + expect(await getUserFollowing(adminUser)).to.eql([user]) }).timeout(10000) it('creates profile when user exists but profile not', async () => { From cfdb3ee3519fcafeec987413398e3ad7934aae9c Mon Sep 17 00:00:00 2001 From: Hongbo Wu Date: Tue, 5 Apr 2022 17:40:36 +0800 Subject: [PATCH 09/18] test two resolver --- packages/api/mocha-config.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/api/mocha-config.json b/packages/api/mocha-config.json index 2fd06093c..411c44041 100644 --- a/packages/api/mocha-config.json +++ b/packages/api/mocha-config.json @@ -1,5 +1,5 @@ { "extension": ["ts"], - "spec": "test/resolvers/article.test.ts", + "spec": ["test/resolvers/article.test.ts", "test/resolvers/highlight.test.ts"], "require": ["test/babel-register.js", "test/global-setup.ts", "test/global-teardown.ts"] } From 1be28df3d74d9f4ccf4f024f05b809d46023c2f8 Mon Sep 17 00:00:00 2001 From: Hongbo Wu Date: Tue, 5 Apr 2022 18:13:15 +0800 Subject: [PATCH 10/18] put spec as an array --- packages/api/mocha-config.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/api/mocha-config.json b/packages/api/mocha-config.json index 411c44041..ec751eed4 100644 --- a/packages/api/mocha-config.json +++ b/packages/api/mocha-config.json @@ -1,5 +1,5 @@ { "extension": ["ts"], - "spec": ["test/resolvers/article.test.ts", "test/resolvers/highlight.test.ts"], + "spec": ["test/**/*.test.ts"], "require": ["test/babel-register.js", "test/global-setup.ts", "test/global-teardown.ts"] } From 7b9bfbdbf5f2dda7bcaea83dae7af0e2d43e2c8c Mon Sep 17 00:00:00 2001 From: Hongbo Wu Date: Tue, 5 Apr 2022 18:23:18 +0800 Subject: [PATCH 11/18] test three resolvers --- packages/api/mocha-config.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/api/mocha-config.json b/packages/api/mocha-config.json index ec751eed4..47bcbeb06 100644 --- a/packages/api/mocha-config.json +++ b/packages/api/mocha-config.json @@ -1,5 +1,5 @@ { "extension": ["ts"], - "spec": ["test/**/*.test.ts"], + "spec": ["test/resolvers/article.test.ts", "test/resolvers/highlight.test.ts", "test/resolvers/label.test.ts"], "require": ["test/babel-register.js", "test/global-setup.ts", "test/global-teardown.ts"] } From 107616b44d7e9bdf066323935bedb0779fa13844 Mon Sep 17 00:00:00 2001 From: Hongbo Wu Date: Tue, 5 Apr 2022 18:45:00 +0800 Subject: [PATCH 12/18] test three resolvers --- packages/api/mocha-config.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/api/mocha-config.json b/packages/api/mocha-config.json index 47bcbeb06..8246a8586 100644 --- a/packages/api/mocha-config.json +++ b/packages/api/mocha-config.json @@ -1,5 +1,5 @@ { "extension": ["ts"], - "spec": ["test/resolvers/article.test.ts", "test/resolvers/highlight.test.ts", "test/resolvers/label.test.ts"], + "spec": ["test/resolvers/article.test.ts", "test/resolvers/highlight.test.ts", "test/resolvers/labels.test.ts"], "require": ["test/babel-register.js", "test/global-setup.ts", "test/global-teardown.ts"] } From 8e525c361ab5f9568051f1d896fac39f2dd09a9f Mon Sep 17 00:00:00 2001 From: Hongbo Wu Date: Tue, 5 Apr 2022 22:29:07 +0800 Subject: [PATCH 13/18] more debugging --- packages/api/mocha-config.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/api/mocha-config.json b/packages/api/mocha-config.json index 8246a8586..f3839d3c9 100644 --- a/packages/api/mocha-config.json +++ b/packages/api/mocha-config.json @@ -1,5 +1,5 @@ { "extension": ["ts"], - "spec": ["test/resolvers/article.test.ts", "test/resolvers/highlight.test.ts", "test/resolvers/labels.test.ts"], + "spec": ["test/resolvers/article.test.ts", "test/resolvers/highlight.test.ts", "test/resolvers/newsletters.test.ts"], "require": ["test/babel-register.js", "test/global-setup.ts", "test/global-teardown.ts"] } From 0bf946ebfab528aef925dece396f239905874626 Mon Sep 17 00:00:00 2001 From: Hongbo Wu Date: Tue, 5 Apr 2022 22:41:29 +0800 Subject: [PATCH 14/18] add reminders test --- packages/api/mocha-config.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/api/mocha-config.json b/packages/api/mocha-config.json index f3839d3c9..5f20d8701 100644 --- a/packages/api/mocha-config.json +++ b/packages/api/mocha-config.json @@ -1,5 +1,5 @@ { "extension": ["ts"], - "spec": ["test/resolvers/article.test.ts", "test/resolvers/highlight.test.ts", "test/resolvers/newsletters.test.ts"], + "spec": ["test/resolvers/article.test.ts", "test/resolvers/highlight.test.ts", "test/resolvers/newsletters.test.ts", "test/resolvers/reminders.test.ts"], "require": ["test/babel-register.js", "test/global-setup.ts", "test/global-teardown.ts"] } From 0b5acd941db6b3f6f9c091052c7ca386560bc805 Mon Sep 17 00:00:00 2001 From: Hongbo Wu Date: Tue, 5 Apr 2022 23:12:17 +0800 Subject: [PATCH 15/18] continue on error in github action --- .github/workflows/run-tests.yaml | 1 + packages/api/mocha-config.json | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/run-tests.yaml b/.github/workflows/run-tests.yaml index c470508b6..71dd1c077 100644 --- a/.github/workflows/run-tests.yaml +++ b/.github/workflows/run-tests.yaml @@ -69,6 +69,7 @@ jobs: yarn build yarn lint yarn test + continue-on-error: true env: PG_HOST: localhost PG_PORT: ${{ job.services.postgres.ports[5432] }} diff --git a/packages/api/mocha-config.json b/packages/api/mocha-config.json index 5f20d8701..b7a0e4f93 100644 --- a/packages/api/mocha-config.json +++ b/packages/api/mocha-config.json @@ -1,5 +1,5 @@ { "extension": ["ts"], - "spec": ["test/resolvers/article.test.ts", "test/resolvers/highlight.test.ts", "test/resolvers/newsletters.test.ts", "test/resolvers/reminders.test.ts"], + "spec": "test/**/*.test.ts", "require": ["test/babel-register.js", "test/global-setup.ts", "test/global-teardown.ts"] } From a269ba270750b1148b07add4fcafa00ec3d142d8 Mon Sep 17 00:00:00 2001 From: Hongbo Wu Date: Tue, 5 Apr 2022 23:20:32 +0800 Subject: [PATCH 16/18] reduce logs --- .github/workflows/run-tests.yaml | 1 - packages/api/test/db.ts | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/run-tests.yaml b/.github/workflows/run-tests.yaml index 71dd1c077..c470508b6 100644 --- a/.github/workflows/run-tests.yaml +++ b/.github/workflows/run-tests.yaml @@ -69,7 +69,6 @@ jobs: yarn build yarn lint yarn test - continue-on-error: true env: PG_HOST: localhost PG_PORT: ${{ job.services.postgres.ports[5432] }} diff --git a/packages/api/test/db.ts b/packages/api/test/db.ts index b92af6ead..dabf86f24 100644 --- a/packages/api/test/db.ts +++ b/packages/api/test/db.ts @@ -52,7 +52,7 @@ const createEntityConnection = async (): Promise => { username: process.env.PG_USER, password: process.env.PG_PASSWORD, database: process.env.PG_DB, - logging: ['query', 'info'], + logging: ['error'], entities: [__dirname + '/../src/entity/**/*{.js,.ts}'], subscribers: [__dirname + '/../src/events/**/*{.js,.ts}'], namingStrategy: new SnakeNamingStrategy(), From e9aa60d40a2d22c2a4310f873332ffaed22d8ff2 Mon Sep 17 00:00:00 2001 From: Hongbo Wu Date: Tue, 5 Apr 2022 23:51:18 +0800 Subject: [PATCH 17/18] lerna no-bail --- package.json | 2 +- packages/api/test/db.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index f42ccfb0e..4985ac42d 100644 --- a/package.json +++ b/package.json @@ -8,7 +8,7 @@ ], "license": "UNLICENSED", "scripts": { - "test": "lerna run test --ignore @omnivore/web", + "test": "lerna run --no-bail test --ignore @omnivore/web", "lint": "lerna run lint --ignore @omnivore/web", "build": "lerna run build --ignore @omnivore/web", "bootstrap": "lerna bootstrap", diff --git a/packages/api/test/db.ts b/packages/api/test/db.ts index dabf86f24..b92af6ead 100644 --- a/packages/api/test/db.ts +++ b/packages/api/test/db.ts @@ -52,7 +52,7 @@ const createEntityConnection = async (): Promise => { username: process.env.PG_USER, password: process.env.PG_PASSWORD, database: process.env.PG_DB, - logging: ['error'], + logging: ['query', 'info'], entities: [__dirname + '/../src/entity/**/*{.js,.ts}'], subscribers: [__dirname + '/../src/events/**/*{.js,.ts}'], namingStrategy: new SnakeNamingStrategy(), From 90eed7cfb4bfef1d2a2393e0f8b831991cd17bb3 Mon Sep 17 00:00:00 2001 From: Hongbo Wu Date: Wed, 6 Apr 2022 00:07:59 +0800 Subject: [PATCH 18/18] revert debug test case --- packages/api/test/resolvers/article.test.ts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/packages/api/test/resolvers/article.test.ts b/packages/api/test/resolvers/article.test.ts index fab47aab8..1dad82e7a 100644 --- a/packages/api/test/resolvers/article.test.ts +++ b/packages/api/test/resolvers/article.test.ts @@ -294,9 +294,7 @@ describe('Article API', () => { it('should create an article', async () => { const res = await graphqlRequest(query, authToken).expect(200) - expect(res.body.data.createArticle.createdArticle.title).not.to.eql( - title - ) + expect(res.body.data.createArticle.createdArticle.title).to.eql(title) pageId = res.body.data.createArticle.createdArticle.id }) })