From d9d71aa443652de9f1aef669d05a962422ff51fb Mon Sep 17 00:00:00 2001
From: Hongbo Wu <hongbo@omnivore.app>
Date: Tue, 5 Sep 2023 17:31:50 +0800
Subject: [PATCH] fix highlights api

---
 packages/api/src/entity/highlight.ts    | 2 +-
 packages/api/src/services/highlights.ts | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/packages/api/src/entity/highlight.ts b/packages/api/src/entity/highlight.ts
index f1044dc7b..f4bae6d38 100644
--- a/packages/api/src/entity/highlight.ts
+++ b/packages/api/src/entity/highlight.ts
@@ -31,7 +31,7 @@ export class Highlight {
   @JoinColumn({ name: 'user_id' })
   user!: User
 
-  @ManyToOne(() => LibraryItem, { onDelete: 'CASCADE' })
+  @ManyToOne(() => LibraryItem, { onDelete: 'CASCADE', eager: true })
   @JoinColumn({ name: 'library_item_id' })
   libraryItem!: LibraryItem
 
diff --git a/packages/api/src/services/highlights.ts b/packages/api/src/services/highlights.ts
index e75003fc4..14c1a00b0 100644
--- a/packages/api/src/services/highlights.ts
+++ b/packages/api/src/services/highlights.ts
@@ -100,8 +100,7 @@ export const deleteHighlightById = async (highlightId: string) => {
       throw new Error(`Highlight ${highlightId} not found`)
     }
 
-    await highlightRepo.remove(highlight)
-
+    await highlightRepo.delete(highlightId)
     return highlight
   })
 }