From d579a8f90796ef0defda159a0261684f3c9c636f Mon Sep 17 00:00:00 2001 From: Hongbo Wu Date: Fri, 15 Dec 2023 13:31:22 +0800 Subject: [PATCH] not throw error if sort keyword not found --- packages/api/src/services/library_item.ts | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/packages/api/src/services/library_item.ts b/packages/api/src/services/library_item.ts index edcf2c732..ecf61067b 100644 --- a/packages/api/src/services/library_item.ts +++ b/packages/api/src/services/library_item.ts @@ -317,18 +317,18 @@ export const buildQuery = ( ) } case 'sort': { - const [sort, sortOrder] = value.split('-') - if (sort.toLowerCase() === 'score') { - // score is not a column and is handled separately + const [sort, sortOrder] = value.toLowerCase().split('-') + const matchingSortBy = Object.values(SortBy).find( + (sortBy) => sortBy === sort + ) + if (!matchingSortBy) { return null } + const column = getColumnName(matchingSortBy) const order = - sortOrder?.toLowerCase() === 'asc' - ? SortOrder.ASCENDING - : SortOrder.DESCENDING + sortOrder === 'asc' ? SortOrder.ASCENDING : SortOrder.DESCENDING - const column = getColumnName(sort) orders.push({ by: `library_item.${column}`, order }) return null }