prehistoric-systems/omnivore
1
0
Fork 0
mirror of https://github.com/omnivore-app/omnivore.git synced 2026-03-11 08:54:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #1593 from omnivore-app/fix/set-labels-for-highlights-conflicts

Browse source 
Not raise error when there is conflict of setting labels in highlights
This commit is contained in:
Hongbo Wu 2022-12-30 11:27:31 +08:00 committed by GitHub
commit ce3d71c1ee
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
packages/api/src/elastic/labels.ts
View file

@ -296,16 +296,14 @@ export const setLabelsForHighlight = async (
conflicts: 'proceed', // ignore conflicts
})
if (!body.updated) {
return false
}
for (const label of labels) {
await ctx.pubsub.entityCreated<Label & { highlightId: string }>(
EntityType.LABEL,
{ highlightId, ...label },
ctx.uid
)
if (body.updated > 0) {
for (const label of labels) {
await ctx.pubsub.entityCreated<Label & { highlightId: string }>(
EntityType.LABEL,
{ highlightId, ...label },
ctx.uid
)
}
}
return true