From b736bc721a8654728e291b641e45e5f76545bb1c Mon Sep 17 00:00:00 2001 From: Jackson Harper Date: Thu, 2 Jun 2022 16:25:27 -0700 Subject: [PATCH] Better image previews when saving from URL --- .../App/AppExtensions/Share/ExtensionSaveService.swift | 4 ++-- apple/OmnivoreKit/Sources/Views/ShareExtensionView.swift | 5 +---- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/apple/OmnivoreKit/Sources/App/AppExtensions/Share/ExtensionSaveService.swift b/apple/OmnivoreKit/Sources/App/AppExtensions/Share/ExtensionSaveService.swift index f1ce8f5a2..943dd94ec 100644 --- a/apple/OmnivoreKit/Sources/App/AppExtensions/Share/ExtensionSaveService.swift +++ b/apple/OmnivoreKit/Sources/App/AppExtensions/Share/ExtensionSaveService.swift @@ -51,13 +51,13 @@ class ExtensionSaveService { shareExtensionViewModel.url = hostname case .none: shareExtensionViewModel.url = hostname - shareExtensionViewModel.title = "Saving: " + payload.url + shareExtensionViewModel.title = payload.url if var url = url { url.path = "/favicon.ico" shareExtensionViewModel.iconURL = url.url?.absoluteString } case let .pdf(localUrl: _): - shareExtensionViewModel.title = "Saving: " + payload.url + shareExtensionViewModel.title = payload.url shareExtensionViewModel.url = hostname } } diff --git a/apple/OmnivoreKit/Sources/Views/ShareExtensionView.swift b/apple/OmnivoreKit/Sources/Views/ShareExtensionView.swift index 011862f6c..14f25c748 100644 --- a/apple/OmnivoreKit/Sources/Views/ShareExtensionView.swift +++ b/apple/OmnivoreKit/Sources/Views/ShareExtensionView.swift @@ -197,13 +197,10 @@ public struct ShareExtensionChildView: View { .aspectRatio(contentMode: .fill) .frame(width: 61, height: 61) .clipped() - } else if case AsyncImageStatus.loading = imageStatus { + } else { Color.appButtonBackground .aspectRatio(contentMode: .fill) .frame(width: 61, height: 61) - } else { - EmptyView() - .frame(width: 61, height: 61) } } } else {